-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: isChain composable #6203
feat: isChain composable #6203
Conversation
SUCCESS @Jarsen136 PR for issue #6202 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
AI-Generated Summary: This pull request introduces a new composable function called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have just kept them under usePrefix
composable, and without arg
WDYT 👀 @vikiival |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise lgtm
Code Climate has analyzed commit 5cee5ad and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But wait we already have something like this, I don't find any advatange to have urlPrefix
as a param
nft-gallery/composables/usePrefix.ts
Lines 43 to 45 in 09d42f3
const isBasilisk = computed( | |
() => prefix.value === 'bsx' || prefix.value === 'snek' | |
) |
pay 20 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
isChain
composable #6202Did your issue had any of the "$" label on it?
Copilot Summary
🤖 Generated by Copilot at dd93446
Refactored the chain detection logic by creating a new
useIsChain
composable that returns computed booleans for each chain based on the prefix. Replaced theisBasilisk
variable from theusePrefix
composable with theuseIsChain
composable in theWalletAssetMenu
andWalletAssetPortfolio
components.🤖 Generated by Copilot at dd93446