feat: unlockable drop landing page #6211

Jarsen136 · 2023-06-13T13:52:57Z

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Needs Design check

@exezbcz please review

Context

Closes unlockable drop landing page #6205
Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

My DOT address: Payout

Screenshot 📸

My fix has changed UI

Copilot Summary

`🤖 Generated by Copilot at c01bff2`

This pull request introduces a new feature for minting NFTs with unlockable content. It adds a new component UnlockableLandingTag that shows a tag for unlockable NFTs on the landing page and allows users to filter by this criterion. It also defines a constant enableUnlockableMintPrefix that specifies which prefixes can use this feature.

`🤖 Generated by Copilot at c01bff2`

Oh, we're the minters of the stmn prefix
We've got a feature that will make you perplex
We can hide some content in our NFTs
And reveal it later with a special key

kodabot · 2023-06-13T13:53:02Z

SUCCESS @Jarsen136 PR for issue #6205 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

netlify · 2023-06-13T13:53:02Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`f4c1f69`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/648b340771577e0008921d0b
😎 Deploy Preview	https://deploy-preview-6211--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

reviewpad · 2023-06-13T13:53:25Z

AI-Generated Summary: This pull request introduces a new unlockable drop landing page. It includes the following changes:

A new UnlockableLandingTag.vue component, which displays a banner for the free Unlockable Mint Live feature.
Updates to the const.ts file, adding an enableUnlockableMintPrefix constant that indicates which URL prefixes should have the unlockable drop landing page enabled.
Modifications to the SearchLanding.vue component to include the UnlockableLandingTag component on the page.

exezbcz · 2023-06-13T14:12:30Z

would be nice to have on every network landing page no? Would it be possible?

Jarsen136 · 2023-06-13T14:45:57Z

would be nice to have on every network landing page no? Would it be possible?

It's possible, but I'm concerned that the user may feel strange seeing the unlockable minting button on other chains except stmn chain. Will we support unlockable minting on other chinas in the future?

exezbcz · 2023-06-13T17:45:11Z

@Jarsen136 Yes. The thing is, they will only know about the drop if they are connected to stmn. Thus I will put it everywhere - the only issue I see on this is that we need a multichain profile, so if the user wants to find it, it takes some time.

Jarsen136 · 2023-06-14T05:50:47Z

would be nice to have on every network landing page no? Would it be possible?

✅ DONE

roiLeo

Small stuff otherwise lgtm ✅

components/collection/unlockable/UnlockableLandingTag.vue

locales/en.json

exezbcz · 2023-06-14T16:11:55Z

thinking about adding a new link to the navbar when there will be a drop page live

yangwao · 2023-06-14T17:26:47Z

🥹

Jarsen136 · 2023-06-15T15:05:45Z

thinking about adding a new link to the navbar when there will be a drop page live

Oh, I missed this one. Have added it.

roiLeo · 2023-06-15T15:09:48Z

components/Navbar.vue

+          <svg
+            class="ml-1"
+            width="13"
+            height="17"
+            viewBox="0 0 13 17"
+            fill="none"
+            xmlns="http://www.w3.org/2000/svg">
+            <path
+              d="M10.9123 7.81131C10.7143 7.55298 10.4732 7.32908 10.2493 7.10519C9.67233 6.58852 9.01788 6.21824 8.46676 5.67573C7.18369 4.4185 6.89952 2.3432 7.71758 0.750122C6.89952 0.94818 6.18479 1.39596 5.57339 1.8868C3.34309 3.67793 2.46475 6.83825 3.51532 9.55078C3.54976 9.63689 3.5842 9.723 3.5842 9.83495C3.5842 10.0244 3.45504 10.1966 3.28281 10.2655C3.08476 10.3516 2.87809 10.3 2.71447 10.1622C2.66531 10.1215 2.62438 10.0718 2.59392 10.0158C1.62085 8.78438 1.46585 7.01908 2.1203 5.60684C0.682228 6.77797 -0.101391 8.75854 0.0105545 10.6272C0.0622218 11.0577 0.113889 11.4883 0.26028 11.9189C0.380836 12.4355 0.613339 12.9522 0.871675 13.4086C1.80169 14.8983 3.41198 15.9661 5.14283 16.1814C6.98563 16.4139 8.9576 16.0781 10.3698 14.8036C11.9457 13.3742 12.4968 11.0836 11.6874 9.12022L11.5754 8.89632C11.3946 8.50021 10.9123 7.81131 10.9123 7.81131ZM8.1912 13.2364C7.95009 13.443 7.55397 13.6669 7.24397 13.753C6.27951 14.0975 5.31506 13.6153 4.74672 13.0469C5.77145 12.8058 6.38285 12.048 6.56368 11.2816C6.71007 10.5927 6.43451 10.0244 6.32257 9.36133C6.21923 8.7241 6.23646 8.18159 6.46896 7.58742C6.63257 7.91465 6.8048 8.24187 7.01147 8.50021C7.67453 9.36133 8.71649 9.74022 8.94038 10.9113C8.97482 11.0319 8.99204 11.1525 8.99204 11.2816C9.01788 11.9877 8.70787 12.7628 8.1912 13.2364Z"
+              fill="#FF7AC3" />
+          </svg>


I would use fire-flame-curved icon

@exezbcz wdyt to replace icon with this one. It looks a little different for me.

https://fontawesome.com/icons/fire-alt?f=classic&s=solid&pc=%23dd83b7

you can use sharp one, does not matter if its not 1:1

codeclimate · 2023-06-15T15:54:11Z

Code Climate has analyzed commit f4c1f69 and detected 0 issues on this pull request.

View more on Code Climate.

yangwao · 2023-06-15T16:56:58Z

legit

pay 50 usd

yangwao · 2023-06-15T16:57:11Z

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.32 USD/DOT ~ 11.574 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x88992340031eabd7aec6f07b23ef432ad9f7efb89a88470e3dfd9322727ee3f5

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

feat: unlockable drop landing page

c01bff2

Jarsen136 requested a review from a team as a code owner June 13, 2023 13:52

Jarsen136 requested review from preschian and roiLeo and removed request for a team June 13, 2023 13:52

reviewpad bot added small Pull request is small waiting-for-review labels Jun 13, 2023

fix: unlockable page for every chain

f183099

roiLeo approved these changes Jun 14, 2023

View reviewed changes

Jarsen136 and others added 2 commits June 14, 2023 21:49

fix: translation key

820f33d

Merge branch 'main' into issue-6205

f9025e8

roiLeo approved these changes Jun 14, 2023

View reviewed changes

locales/en.json Outdated Show resolved Hide resolved

Jarsen136 added 2 commits June 14, 2023 22:04

fix: replace custom icon with NeoIcon

abe8961

fix: remove space

fe87ef6

yangwao added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jun 15, 2023

Jarsen136 added 2 commits June 15, 2023 22:52

Merge branch 'main' into issue-6205

8f9bf34

fix: drop entry on navbar

3e4709f

Jarsen136 requested a review from exezbcz June 15, 2023 15:04

roiLeo reviewed Jun 15, 2023

View reviewed changes

fix: replace with neo icon

f4c1f69

yangwao merged commit c7f140d into kodadot:main Jun 15, 2023
17 of 19 checks passed

yangwao added the paid pull-request has been paid label Jun 15, 2023

This was referenced Jun 15, 2023

beta update #6240

Merged

release update #6241

Merged

beta update #6302

Merged

release update #6303

Merged

beta update #6304

Merged

release update #6305

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: unlockable drop landing page #6211

feat: unlockable drop landing page #6211

Jarsen136 commented Jun 13, 2023 •

edited by ghost

kodabot commented Jun 13, 2023

netlify bot commented Jun 13, 2023 •

edited

reviewpad bot commented Jun 13, 2023

exezbcz commented Jun 13, 2023

Jarsen136 commented Jun 13, 2023

exezbcz commented Jun 13, 2023

Jarsen136 commented Jun 14, 2023

roiLeo left a comment

exezbcz commented Jun 14, 2023

yangwao commented Jun 14, 2023

Jarsen136 commented Jun 15, 2023

roiLeo Jun 15, 2023

Jarsen136 Jun 15, 2023

exezbcz Jun 15, 2023

Jarsen136 Jun 15, 2023

codeclimate bot commented Jun 15, 2023

yangwao commented Jun 15, 2023

yangwao commented Jun 15, 2023

feat: unlockable drop landing page #6211

feat: unlockable drop landing page #6211

Conversation

Jarsen136 commented Jun 13, 2023 • edited by ghost

PR Type

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

Copilot Summary

🤖 Generated by Copilot at c01bff2

🤖 Generated by Copilot at c01bff2

kodabot commented Jun 13, 2023

netlify bot commented Jun 13, 2023 • edited

✅ Deploy Preview for koda-canary ready!

reviewpad bot commented Jun 13, 2023

exezbcz commented Jun 13, 2023

Jarsen136 commented Jun 13, 2023

exezbcz commented Jun 13, 2023

Jarsen136 commented Jun 14, 2023

roiLeo left a comment

Choose a reason for hiding this comment

exezbcz commented Jun 14, 2023

yangwao commented Jun 14, 2023

Jarsen136 commented Jun 15, 2023

roiLeo Jun 15, 2023

Choose a reason for hiding this comment

Jarsen136 Jun 15, 2023

Choose a reason for hiding this comment

exezbcz Jun 15, 2023

Choose a reason for hiding this comment

Jarsen136 Jun 15, 2023

Choose a reason for hiding this comment

codeclimate bot commented Jun 15, 2023

yangwao commented Jun 15, 2023

yangwao commented Jun 15, 2023

Jarsen136 commented Jun 13, 2023 •

edited by ghost

`🤖 Generated by Copilot at c01bff2`

`🤖 Generated by Copilot at c01bff2`

netlify bot commented Jun 13, 2023 •

edited