Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 slider input number padding #6219

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 14, 2023

Something that has been bothering me for some time

I've increase padding in action slide buttons

beta
Screenshot 2023-06-14 at 15-48-32 punkd2 KodaDot - NFT Market Explorer
Screenshot 2023-06-14 at 15-48-51 punkd2 KodaDot - NFT Market Explorer

preview
Screenshot 2023-06-14 at 15-37-45 Kid KodaDot - NFT Market Explorer
Screenshot 2023-06-14 at 15-45-54 No anime KodaDot - NFT Market Explorer
Screenshot 2023-06-14 at 15-45-36 UNIV7 KodaDot - NFT Market Explorer
Screenshot 2023-06-14 at 15-45-07 UNIV7 KodaDot - NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner June 14, 2023 13:49
@roiLeo roiLeo requested review from daiagi and Jarsen136 and removed request for a team June 14, 2023 13:49
@netlify
Copy link

netlify bot commented Jun 14, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 092babc
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6489c55434c1d300088dcb3d
😎 Deploy Preview https://deploy-preview-6219--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 14, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 14, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Jun 14, 2023

Code Climate has analyzed commit 092babc and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 14, 2023

AI-Generated Summary: This pull request contains two patches. The first patch modifies the padding in the slider input number for GalleryItemOffer.vue and GalleryItemRelist.vue components. The second patch updates the input numbers' padding and placeholder texts within GalleryItemOffer.vue, GalleryItemRelist.vue, and GalleryItemTransfer.vue. Overall, the changes provide a better UI experience for users when interacting with these components.

@prury
Copy link
Member

prury commented Jun 14, 2023

image

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 14, 2023
@yangwao
Copy link
Member

yangwao commented Jun 14, 2023

I think this is bit not perfect design tbh, are possible have custom design those slider buttons?

let's merge it, it was cutting my eyes for while 🥹

@yangwao yangwao merged commit c985563 into kodadot:main Jun 14, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants