Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Progress indicator styling #6228

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jun 15, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at 3a315e2

Created a new UnlockableSlider component to replace o-slider and show unlockable progress in UnlockableContainer.vue. This improves the user experience and code organization for the unlockable feature.

🤖 Generated by Copilot at 3a315e2

To show how much progress you've made
o-slider had to be replaced
With UnlockableSlider
A custom provider
Of a better and smoother display

@Jarsen136 Jarsen136 requested a review from a team as a code owner June 15, 2023 01:51
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team June 15, 2023 01:51
@netlify
Copy link

netlify bot commented Jun 15, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3a315e2
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/648a6eab6151aa0008e2a4aa
😎 Deploy Preview https://deploy-preview-6228--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Jun 15, 2023

SUCCESS @Jarsen136 PR for issue #6206 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 15, 2023

AI-Generated Summary: This pull request introduces new styling for the progress indicator of the unlockable feature. It includes the creation of a new UnlockableSlider.vue component, which is now used in UnlockableContainer.vue instead of the previous o-slider component. The new slider component has custom styling, including width calculation based on the value prop.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 15, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 15, 2023

Code Climate has analyzed commit 3a315e2 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello have you heard of progress element

@vikiival
Copy link
Member

Hello have you heard of progress element

So can we get some <progress /> on this?

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As pointed out please use progress

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Jun 15, 2023

Hello have you heard of progress element

I have not heard of it before TBH. However, after I did some search on it, I find that it's not that proper. If we use < progress /> directly, it would work well but the style looks not good. Then If we would like to custom the style of it, there are some problems.
I have to use some of these classes to decorate it, but all of these class are Non-standard and may not work for every browser.
image
image
image

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/progress
https://developer.mozilla.org/en-US/docs/Web/CSS/::-moz-progress-bar
https://developer.mozilla.org/en-US/docs/Web/CSS/::-webkit-progress-bar
https://developer.mozilla.org/en-US/docs/Web/CSS/::-webkit-progress-value

In short, for now I use two simple

elements to implement the progress component. I guess it's an easy and stable solution.

@yangwao
Copy link
Member

yangwao commented Jun 15, 2023

pay 30 usd

@yangwao yangwao merged commit 328aad3 into kodadot:main Jun 15, 2023
18 of 20 checks passed
@yangwao
Copy link
Member

yangwao commented Jun 15, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.3 USD/DOT ~ 6.977 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x0972857651429af38f5938ad19726aee65d45dcb7fb8c91a4740041c58920f77

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅ small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress indicator styling
6 participants