Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 error layout #6244

Merged
merged 2 commits into from
Jun 16, 2023
Merged

🔧 error layout #6244

merged 2 commits into from
Jun 16, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 16, 2023

  • vue3 composition api
  • remove box background

Screenshot 2023-06-16 at 09-44-17 KodaDot - NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner June 16, 2023 07:45
@roiLeo roiLeo requested review from preschian and daiagi and removed request for a team June 16, 2023 07:45
@netlify
Copy link

netlify bot commented Jun 16, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4421541
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/648c1300821ef3000864aa2f
😎 Deploy Preview https://deploy-preview-6244--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 16, 2023

AI-Generated Summary: This pull request includes two patches for the error layout. The first patch modifies the error layout template, adding a NeoButton component and updating the scripting language with new components and computed properties. The second patch removes a commented-out line of code related to error messages. Overall, these patches aim to improve the display and handling of various error types.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 16, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 16, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Jun 16, 2023

Code Climate has analyzed commit 4421541 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo enabled auto-merge June 16, 2023 08:33
@roiLeo roiLeo merged commit 72503d2 into kodadot:main Jun 16, 2023
17 of 19 checks passed
@roiLeo roiLeo deleted the hotfix/error/layout branch June 16, 2023 08:47
This was referenced Jun 21, 2023
This was referenced Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants