-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Filter out markdown for og:description #6348
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request includes changes in two files to filter out markdown from og:description. A new utility function |
I've tested on discord and telegram, works fine. |
Sir I think this is not correct. I guess @yangwao wanted to strip out markdown stuff like * [] # |
Co-authored-by: Luke Fishman <daiagi@gmail.com>
Code Climate has analyzed commit 07f157a and detected 0 issues on this pull request. View more on Code Climate. |
@Jarsen136 using a link that directs to the collection is still not showing the description without the markdown: if i use the NFT inside the collection it works properly: |
It should be related to the cache from discord. Pls use telegram to test the url sharing again. @prury |
i had tested on telegram aswell: might also be a cache problem, any other place where i can test it? |
Yes. It's cache. You could test with this link to refresh the cache. https://deploy-preview-6348--koda-canary.netlify.app/stmn/collection/30?t=2 |
works fine ty, will just do a general check and i'll change the label |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
before:
after:
Did your issue had any of the "$" label on it?
Copilot Summary
🤖 Generated by Copilot at 93ebc72
Added a function to detect markdown in strings and used it to remove markdown from collection descriptions in meta tags. This improves SEO by providing cleaner and more relevant metadata for collections.
🤖 Generated by Copilot at 93ebc72