Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drops pages could have dedicated og:image #6363

Merged
merged 11 commits into from
Jul 5, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jun 29, 2023

@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 999937a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64a43da9708e790008bcc956
😎 Deploy Preview https://deploy-preview-6363--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 29, 2023

AI-Generated Summary: This pull request addresses a bug where drop pages were not having their dedicated open graph images (og:image). It introduces several changes across multiple files to resolve this.

In 'DropContainer.vue', 'UnlockableCollectionBanner.vue', and 'UnlockableContainer.vue', the open graph meta tags have been updated with the correct description and image sources. The files also have additional imports for 'unlockableDesc' and 'convertMarkdownToText' from the utils.

In 'DropContainer.vue', the 'handleSubmitMint' function's 'createUnlockableMetadata' call has been updated to include a description.

In 'UnlockableContainer.vue', similar changes as 'DropContainer.vue' are applied. The 'handleSubmitMint' function now submits an image and a description for creating the unlockable metadata.

Lastly, in 'utils.ts', the function 'createUnlockableMetadata' has been modified to have two parameters, 'imageHash' and 'description'.

Overall, these changes should provide a dedicated og:image meta tag for each drop page, enhancing the website's SEO.

@reviewpad reviewpad bot added the small Pull request is small label Jun 29, 2023
@Jarsen136
Copy link
Contributor Author

Emm. I still do not figure out why it does not work, as the seo tag had been updated accordingly.

link: https://deploy-preview-6363--koda-canary.netlify.app/stmn/drops/free-drop
image

The preview information is still the same as the previous one.
image

@Jarsen136 Jarsen136 marked this pull request as ready for review June 30, 2023 16:53
@Jarsen136 Jarsen136 requested a review from a team as a code owner June 30, 2023 16:53
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team June 30, 2023 16:53
@prury
Copy link
Member

prury commented Jun 30, 2023

/drops shows the image correctly
drops/free-drop shows the image correctly
items inside the drop collection shows their respective image/description
tested on: twitter, telegram, discord (open graph site wont load the image, don't know why, but not important.)

as Jarsen said, the right description for the drop link still won't show

opengraph tags, if it helps:

  <!-- HTML Meta Tags -->
  <title>undefined</title>
  <meta name="description" content="undefined">

  <!-- Facebook Meta Tags -->
  <meta property="og:url" content="https://deploy-preview-6363--koda-canary.netlify.app/stmn/drops/free-drop">
  <meta property="og:type" content="website">
  <meta property="og:title" content="undefined">
  <meta property="og:description" content="undefined">
  <meta property="og:image" content="">

  <!-- Twitter Meta Tags -->
  <meta name="twitter:card" content="summary_large_image">
  <meta property="twitter:domain" content="deploy-preview-6363--koda-canary.netlify.app">
  <meta property="twitter:url" content="https://deploy-preview-6363--koda-canary.netlify.app/stmn/drops/free-drop">
  <meta name="twitter:title" content="undefined">
  <meta name="twitter:description" content="undefined">
  <meta name="twitter:image" content="">

  <!-- Meta Tags Generated via https://www.opengraph.xyz -->
        

@roiLeo
Copy link
Contributor

roiLeo commented Jul 3, 2023

maybe something related with kodadot workers? ssr-opengraph?

@preschian
Copy link
Member

Emm. I still do not figure out why it does not work, as the seo tag had been updated accordingly.

link: deploy-preview-6363--koda-canary.netlify.app/stmn/drops/free-drop

seems like prerendering on netlify is not working. I can help with canary/beta by using worker
so, what we can do in this PR is validate the metadata (or image) on the client side by using chrome extension

I will open the PR on the workers side

Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjust e2e test? otherwise lgtm 👍

@codeclimate
Copy link

codeclimate bot commented Jul 4, 2023

Code Climate has analyzed commit 999937a and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

adjust e2e test? otherwise lgtm 👍

✅ E2E test pass

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 4, 2023
@prury
Copy link
Member

prury commented Jul 4, 2023

Emm. I still do not figure out why it does not work, as the seo tag had been updated accordingly.
link: deploy-preview-6363--koda-canary.netlify.app/stmn/drops/free-drop

seems like prerendering on netlify is not working. I can help with canary/beta by using worker so, what we can do in this PR is validate the metadata (or image) on the client side by using chrome extension

I will open the PR on the workers side

image
image
image
image

https://og-image-green-seven.vercel.app/Waifu%20T-Shirt%20Free%20Mint.jpeg?image=https%3A%2F%2Freplicate.delivery%2Fpbxt%2FDqeaImcF1W3AcCeBw2EwCxpvss9CBHM2oeZKBBfHMrqSmzpEB%2Fout-0.png

@preschian preschian enabled auto-merge July 5, 2023 05:59
@yangwao yangwao disabled auto-merge July 5, 2023 18:48
@yangwao yangwao merged commit c4dc0df into kodadot:main Jul 5, 2023
18 of 19 checks passed
This was referenced Jul 5, 2023
This was referenced Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drops pages could have dedicated og:image
5 participants