Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 migrate b-pagination #6366

Merged
merged 4 commits into from
Jul 3, 2023
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 30, 2023

part of #5852

Tested on /bsx/u/bXmx9pNXZw6dYkwaoafJyTrAZVQ1znGq8boJHC2MfQwgGLxPz?page=1

⚠️ note: I am aware that pagination don't work on "Created" tab even on beta and prod

  • fix design issue
  • fix random magic button
  • pagination vue composition api

Screenshot 2023-06-30 at 17-09-59 NFT Artist Profile on KodaDot KodaDot - NFT Market Explorer

Screenshot 2023-06-30 at 17-14-59 NFT Artist Profile on KodaDot KodaDot - NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner June 30, 2023 15:11
@roiLeo roiLeo requested review from vikiival and Jarsen136 and removed request for a team June 30, 2023 15:11
@netlify
Copy link

netlify bot commented Jun 30, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ce7757f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64a26525cba5530008cb607d
😎 Deploy Preview https://deploy-preview-6366--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 30, 2023

AI-Generated Summary: This pull request involves a significant refactor and update to the pagination component in the application.

Major changes include:

  • Replacement of 'b-pagination' with a new 'NeoPagination' component.
  • Migration of functionality from the class-based component structure to the Composition API with the script setup syntax. This includes removal of mixins and props declaration through decorators to the use of defineProps and computed methods.
  • Creation of a new 'NeoPagination.vue' component and adding it to the export list in the index file of the ui library.
  • Significant update to the gallery pagination styles, functions, and event handlers with the removal of several lines of code.
  • Removal of pagination related styles from '_variables.scss' and 'global.scss' and correction of some formatting inconsistencies.
  • Introduction of better methods for scrolling and URL replacement.

This patch not only reduces the complexity of the code but also makes it more in line with Vue 3 style of coding and probable to perform better.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Jun 30, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 30, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo mentioned this pull request Jun 30, 2023
37 tasks
@prury
Copy link
Member

prury commented Jun 30, 2023

Like @roiLeo pointed, there are some bugs/mobile design flaws that were already occurring on beta, since we are going for a future profile page redesign, best to wait for to avoid unnecessary workforce use.

IMO, in the future, the way pages are switched, their behavior when switching it and some other minor aspects should be reevaluated to give users a better experience.

otherwise, the change to Neo Pagination work as intended.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 30, 2023
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise OKI

components/rmrk/Gallery/Pagination.vue Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Jul 3, 2023

Code Climate has analyzed commit ce7757f and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo mentioned this pull request Jul 3, 2023
@roiLeo roiLeo enabled auto-merge July 3, 2023 06:08
@roiLeo roiLeo merged commit c571465 into kodadot:main Jul 3, 2023
12 of 14 checks passed
This was referenced Jul 5, 2023
This was referenced Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants