-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 migrate b-pagination #6366
🔧 migrate b-pagination #6366
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request involves a significant refactor and update to the pagination component in the application. Major changes include:
This patch not only reduces the complexity of the code but also makes it more in line with Vue 3 style of coding and probable to perform better. |
Reviewpad Report
|
Like @roiLeo pointed, there are some bugs/mobile design flaws that were already occurring on beta, since we are going for a future profile page redesign, best to wait for to avoid unnecessary workforce use. IMO, in the future, the way pages are switched, their behavior when switching it and some other minor aspects should be reevaluated to give users a better experience. otherwise, the change to Neo Pagination work as intended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise OKI
Code Climate has analyzed commit ce7757f and detected 0 issues on this pull request. View more on Code Climate. |
part of #5852
Tested on
/bsx/u/bXmx9pNXZw6dYkwaoafJyTrAZVQ1znGq8boJHC2MfQwgGLxPz?page=1