Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 libs/ui package #6368

Merged
merged 2 commits into from
Jul 1, 2023
Merged

🔧 libs/ui package #6368

merged 2 commits into from
Jul 1, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 30, 2023

prepare #5611

  • fix issues from libs/ui (pnpm run story:dev)
  • move IdentityItem component

@roiLeo roiLeo requested a review from a team as a code owner June 30, 2023 19:26
@roiLeo roiLeo requested review from vikiival and Jarsen136 and removed request for a team June 30, 2023 19:26
@netlify
Copy link

netlify bot commented Jun 30, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit a762ce2
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/649f2c4add5c63000866b3e0
😎 Deploy Preview https://deploy-preview-6368--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 30, 2023

AI-Generated Summary: This pull request includes changes across a number of Vue.js UI components as well as style files. Notably, it deletes the IdentityItem component and the NeoInput story from the libs/ui/src/components/ directory, and introduces a number of changes to other files, such as the WalletAssetIdentity.vue and GalleryItem.vue files.

The component IdentityItem is then reintroduced in a different location, specifically in the components/identity directory. It also tweaks the CSS in DisablableTab.scss and _variables.scss.

The import paths in some files have been changed accordingly. In the index.ts file at the libs/ui/src/ directory, the IdentityItem has been removed from exports.

Overall, this patch includes both file deletions and additions along with modifications in a number of other files in the libs/ui/src/components/ and styles/abstracts/ directories. Most of these changes appear to be related to component organization and styling.

@codeclimate
Copy link

codeclimate bot commented Jun 30, 2023

Code Climate has analyzed commit a762ce2 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 30, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 30, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 30, 2023
@vikiival vikiival merged commit 21d7704 into kodadot:main Jul 1, 2023
18 of 19 checks passed
This was referenced Jul 5, 2023
This was referenced Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants