Fix/simple-mint #6380

daiagi · 2023-07-04T05:39:25Z

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Needs QA check

@prury please review

Context

Closes Simple Minting on Kusama - Editions not working #6343
Closes Fix distribution on rmrk/mint #6388
Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

My DOT address: Payout

Screenshot 📸

My fix has changed UI

Copilot Summary

`🤖 Generated by Copilot at b2f1e61`

Fixed a type bug in the simple minting component and added support for minting NFTs under existing collections by providing the collection ID as a string. Modified the getNftId function in scheme.ts to handle both cases.

`🤖 Generated by Copilot at b2f1e61`

To mint NFTs with more ease
We added a new feature, please
Check the nft.collection
And its type detection
And fix the rmrkMint.max keys

…irect in simple mint

kodabot · 2023-07-04T05:39:30Z

WARNING @daiagi PR for issue #6343 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6343

netlify · 2023-07-04T05:39:39Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`a046296`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/64a62b0314100f0008e8eee5
😎 Deploy Preview	https://deploy-preview-6380--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

reviewpad · 2023-07-04T05:39:45Z

AI-Generated Summary: This pull request includes two patches. The first patch makes a modification in 'SimpleMint.vue' to ensure that 'this.rmrkMint.max' is assigned as a number to avoid type related errors or inconsistencies. The patch also modifies the 'syncEdition' and 'sub' methods to ensure compatibility with this change. The second patch addresses an issue in 'getNftId' function within 'service/scheme.ts'. The fix is to handle a scenario where the 'collection' property of 'nft' is not an object but a string, by checking its type before using it to construct the 'collectionId'.

components/rmrk/Create/SimpleMint.vue

components/rmrk/service/scheme.ts

prury · 2023-07-04T13:09:40Z

First test:

tx: https://kusama.subscan.io/tx/0x24af384214522020f7262e4f6059e9b2e05bf338982f899b1d5539dfeae9e8b7
tx: https://kusama.subscan.io/tx/0xc43177b96299c8435b79e9fbcaf9afae80e43662987b4913792b2be23157fa10

4 editions successfully minted:

Distribution:

I've set the distribution to 75% via slider, as i understood 3 of 4 NFTs should have been sent to the addresses i had filled, but none got sent.

@daiagi I'll open another issue to fix distribution

…x/simple-mint

daiagi · 2023-07-04T13:50:29Z

successful mint with 2 editions:
https://kusama.subscan.io/extrinsic/18641451-5
/rmrk/collection/C4F63647002B182C0E-WOLF

successful mint with 2 editions + list for sell:
mint: https://kusama.subscan.io/extrinsic/18641561-3
list: https://kusama.subscan.io/extrinsic/18641565-3
/rmrk/collection/C4F63647002B182C0E-WOLF2

redirect after mint success (with and w/o listing for sell)

bugs for other issues:

no loader animation during the list for sell transaction
I've set the distribution to 75% via slider, as i understood 3 of 4 NFTs should have been sent to the addresses i had filled, but none got sent.

vikiival · 2023-07-04T14:07:31Z

I've set the distribution to 75% via slider, as i understood 3 of 4 NFTs should have been sent to the addresses i had filled, but none got sent.

I am checking the code that I have written around 06/2021

How it works:

we parse all addressed
shuffle them via on-chain randomness
if distributon is set (e.g 75) - from 4 addr we take 3
4a. if you have less tokens than addresses let's say 2 we will take first 2 addresses
4b. if you have more tokens (10) we take 3 addresses as stated in step 3
transfer tx is done

If you see some logical error (it does not make sense) we can still change the algo

prury · 2023-07-04T14:41:52Z

I've set the distribution to 75% via slider, as i understood 3 of 4 NFTs should have been sent to the addresses i had filled, but none got sent.

I am checking the code that I have written around 06/2021

How it works:
1. we parse all addressed

2. shuffle them via on-chain randomness

3. if distributon is set (e.g 75) - from 4 addr we take 3
   4a. if you have less tokens than addresses let's say 2 we will take first 2 addresses
   4b. if you have more tokens (10) we take 3 addresses as stated in step 3

4. transfer tx is done
If you see some logical error (it does not make sense) we can still change the algo

oh, it works like a random draw thing then
the collection I've created had 4 nfts, 3 addresses and a 75% distribution percentage
at least 2 should have been transferred, but no one got an NFT

vikiival · 2023-07-04T14:47:01Z

but no one got an NFT

ah @daiagi I know
In: @components/accounts/utils
line 57
you need to pass different version 💯

daiagi · 2023-07-04T14:57:22Z

but no one got an NFT

ah @daiagi I know In: @components/accounts/utils line 57 you need to pass different version 💯

@vikiival I removed the version param as per createInteraction signature:

vikiival · 2023-07-04T15:01:03Z

I removed the version param as per createInteraction signature:

Oh therefore you need to import also createInteraction from minimark/v2 and if prefix is kusama then use v2

daiagi · 2023-07-04T15:06:06Z

Oh therefore you need to import also createInteraction from minimark/v2 and if prefix is kusama then use v2

alrighty, to be continued tommorow

daiagi · 2023-07-05T03:55:43Z

Oh therefore you need to import also createInteraction from minimark/v2 and if prefix is kusama then use v2

done
@prury wanna give it a try?

vikiival

Should be oki now

prury · 2023-07-05T12:12:06Z

Oh therefore you need to import also createInteraction from minimark/v2 and if prefix is kusama then use v2

done @prury wanna give it a try?

lemme try

prury · 2023-07-05T12:27:09Z

Seems that is working, let me do another one
number of editions: 5
number of addresses: 3
distribution percentage: 60%
60% of 3 = 1.8
1 NFT was successfully sent.

collection:
https://deploy-preview-6380--koda-canary.netlify.app/rmrk/collection/7EA1DCF47E98A25067-FB?collectionId=7EA1DCF47E98A25067-FB

transferred NFT:
https://deploy-preview-6380--koda-canary.netlify.app/rmrk/gallery/18655081-7EA1DCF47E98A25067-FB-FUTURISTIC_BUILDING_1-0000000000000001

minting:
https://kusama.subscan.io/tx/0x1a562ce19e6b645828bed07ffd2bace6dab91241633fe933924f6525ad88fa91
transfer:
https://kusama.subscan.io/tx/0x29a6243a7d226ea4fffef1b2ecf716865166122ca5d805426785f41dbb0bed59

prury · 2023-07-05T12:54:09Z

trying now with less copies than addresses:

Settings:
2 editions
listing for 0.4
4 addresses
100% distribution

collection:
https://deploy-preview-6380--koda-canary.netlify.app/rmrk/collection/7EA1DCF47E98A25067-IH?collectionId=7EA1DCF47E98A25067-IH

NFTs got sent successfully

https://kusama.subscan.io/tx/0x834d2c358595380661d4395f2c67f271d7066756c02691a7aa2f15fa0b2453e3
https://kusama.subscan.io/tx/0x9265ce9d0f536a5b8d805f0b2f0e25f86ddf3a2110bc12bc1f6e3be94f63cc4f

obs: listing was just a unused extra step because i was transferring them to other accounts

@daiagi is it possible to change Editions to Copies like we did for statemine?

prury · 2023-07-05T13:05:33Z

last one:
https://deploy-preview-6380--koda-canary.netlify.app/rmrk/collection/7EA1DCF47E98A25067-ANIME90?collectionId=7EA1DCF47E98A25067-ANIME90

settings:
4 addresses
6 editions
list for 0.3 ksm
distribution: 80%

3 got sent 3 got listed

https://kusama.subscan.io/tx/0x63c6df3ba148c7a1b4f64c9648f35cefa1dfc0b82b64358f20d39c6d456cd6bc
https://kusama.subscan.io/tx/0x9256363daf71777212bd5734789a1cc7d42a1bc3f5456d9b8d939c8a5f4ddc30

vikiival · 2023-07-05T13:08:47Z

I got NFT 🥹

…x/simple-mint

codeclimate · 2023-07-06T02:46:52Z

Code Climate has analyzed commit a046296 and detected 0 issues on this pull request.

View more on Code Climate.

daiagi · 2023-07-06T02:46:53Z

is it possible to change Editions to Copies like we did for statemine?

yes. done

vikiival · 2023-07-06T10:14:13Z

Sooo let's merge this

vikiival · 2023-07-06T10:14:31Z

pay 100 usd

yangwao · 2023-07-06T10:14:41Z

😍 Perfect, I’ve sent the payout
💵 $100 @ 5.29 USD/DOT ~ 18.904 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0x993cd44ec0d6ead6f671d789c2d21c7ecd7501e64726edd8e17fdf3566774d03

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

daiagi added 2 commits July 4, 2023 12:37

🔧 editions bug

03dd66b

hotfix: getNftId => inconsistent nft.collection type breaks list, red…

b2f1e61

…irect in simple mint

daiagi requested a review from a team as a code owner July 4, 2023 05:39

daiagi requested review from preschian and Jarsen136 and removed request for a team July 4, 2023 05:39

reviewpad bot added small Pull request is small waiting-for-review labels Jul 4, 2023

Jarsen136 reviewed Jul 4, 2023

View reviewed changes

components/rmrk/Create/SimpleMint.vue Show resolved Hide resolved

remove duplicate consersion to number

7d217a9

vikiival reviewed Jul 4, 2023

View reviewed changes

components/rmrk/service/scheme.ts Outdated Show resolved Hide resolved

preschian approved these changes Jul 4, 2023

View reviewed changes

daiagi added 2 commits July 4, 2023 20:40

typing change + use existing minimark utils

6b2d333

Merge branch 'main' of https://github.com/kodadot/nft-gallery into fi…

66e8c35

…x/simple-mint

daiagi requested a review from vikiival July 4, 2023 13:51

prury mentioned this pull request Jul 4, 2023

Fix distribution on rmrk/mint #6388

Closed

1 task

🔧 remove version param from call to cerateInteraction@ simpleMint

b510ded

prury mentioned this pull request Jul 4, 2023

No loading when listing assets using rmrk/mint #6389

Closed

1 task

V2 send (simple mint)

63792c7

vikiival reviewed Jul 5, 2023

View reviewed changes

Jarsen136 approved these changes Jul 5, 2023

View reviewed changes

prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 5, 2023

daiagi added 3 commits July 6, 2023 09:45

🔧 typing

044ce22

edition => copies

ba79f06

Merge branch 'main' of https://github.com/kodadot/nft-gallery into fi…

a046296

…x/simple-mint

vikiival merged commit f59f101 into main Jul 6, 2023
18 of 19 checks passed

vikiival deleted the fix/simple-mint branch July 6, 2023 10:14

yangwao added the paid pull-request has been paid label Jul 6, 2023

This was referenced Jul 17, 2023

beta update #6435

Merged

release update #6436

Merged

prury mentioned this pull request Aug 30, 2023

SimpleMint to composition API #7038

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/simple-mint #6380

Fix/simple-mint #6380

daiagi commented Jul 4, 2023 •

edited

kodabot commented Jul 4, 2023

netlify bot commented Jul 4, 2023 •

edited

reviewpad bot commented Jul 4, 2023

prury commented Jul 4, 2023

daiagi commented Jul 4, 2023

vikiival commented Jul 4, 2023

prury commented Jul 4, 2023

vikiival commented Jul 4, 2023

daiagi commented Jul 4, 2023

vikiival commented Jul 4, 2023

daiagi commented Jul 4, 2023 •

edited

daiagi commented Jul 5, 2023

vikiival left a comment

prury commented Jul 5, 2023

prury commented Jul 5, 2023

prury commented Jul 5, 2023 •

edited

prury commented Jul 5, 2023

vikiival commented Jul 5, 2023

codeclimate bot commented Jul 6, 2023

daiagi commented Jul 6, 2023

vikiival commented Jul 6, 2023

vikiival commented Jul 6, 2023

yangwao commented Jul 6, 2023

Fix/simple-mint #6380

Fix/simple-mint #6380

Conversation

daiagi commented Jul 4, 2023 • edited

PR Type

Needs QA check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

Copilot Summary

🤖 Generated by Copilot at b2f1e61

🤖 Generated by Copilot at b2f1e61

kodabot commented Jul 4, 2023

netlify bot commented Jul 4, 2023 • edited

✅ Deploy Preview for koda-canary ready!

reviewpad bot commented Jul 4, 2023

prury commented Jul 4, 2023

daiagi commented Jul 4, 2023

vikiival commented Jul 4, 2023

prury commented Jul 4, 2023

vikiival commented Jul 4, 2023

daiagi commented Jul 4, 2023

vikiival commented Jul 4, 2023

daiagi commented Jul 4, 2023 • edited

daiagi commented Jul 5, 2023

vikiival left a comment

Choose a reason for hiding this comment

prury commented Jul 5, 2023

prury commented Jul 5, 2023

prury commented Jul 5, 2023 • edited

prury commented Jul 5, 2023

vikiival commented Jul 5, 2023

codeclimate bot commented Jul 6, 2023

daiagi commented Jul 6, 2023

vikiival commented Jul 6, 2023

vikiival commented Jul 6, 2023

yangwao commented Jul 6, 2023

daiagi commented Jul 4, 2023 •

edited

`🤖 Generated by Copilot at b2f1e61`

`🤖 Generated by Copilot at b2f1e61`

netlify bot commented Jul 4, 2023 •

edited

daiagi commented Jul 4, 2023 •

edited

prury commented Jul 5, 2023 •

edited