Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6387 alignment fix #6401

Merged
merged 5 commits into from
Jul 13, 2023
Merged

#6387 alignment fix #6401

merged 5 commits into from
Jul 13, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Jul 5, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
    Screen Shot 2023-07-05 at 4 16 51 PM
    Screen Shot 2023-07-05 at 4 17 12 PM

Copilot Summary

@prachi00 prachi00 requested a review from a team as a code owner July 5, 2023 23:18
@prachi00 prachi00 requested review from preschian and vikiival and removed request for a team July 5, 2023 23:18
@kodabot
Copy link
Collaborator

kodabot commented Jul 5, 2023

WARNING @prachi00 PR for issue #6387 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6387

@netlify
Copy link

netlify bot commented Jul 5, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ed42c73
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64af2fa75501bb0007a0fa1f
😎 Deploy Preview https://deploy-preview-6401--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 5, 2023

AI-Generated Summary: This pull request introduces alignment changes to the 'SearchSuggestion.vue' component in the NeoTabItem instances. The changes included are: the addition of a new property 'item-header-class' that applies specific styling to the item header, and formatting changes in the layout of the NeoTabItem components for 'Collections', 'NFTs', and 'User'. Overall, three lines have been removed, and twelve new lines have been added for better alignment and readability.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 5, 2023
preschian
preschian previously approved these changes Jul 6, 2023
View reviewed changes
roiLeo
roiLeo suggested changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!
Design should look like this

ref #6370 (review)

edit: did someone overwritte the changes?

@preschian preschian dismissed their stale review July 6, 2023 06:51

not aligned with design #6401 (review)

@preschian
Copy link
Member

preschian commented Jul 6, 2023 •
edited

edit: did someone overwritte the changes?

from this PR maybe #6231

maybe because the css selector was different. and then the style was changed

@roiLeo roiLeo added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 6, 2023
@prachi00
Copy link
Member Author

prachi00 commented Jul 7, 2023

uh I see the pink border, did it not get removed in #6370 , should it be removed again?
@roiLeo @exezbcz

@exezbcz
Copy link
Member

exezbcz commented Jul 8, 2023

image
the issue was created only for aligning the tab sections to left - the rest was working nicely

  • the divider is not an active state indicator - that means it should always have k-shade color

image

  • 32px padding, please

@prachi00
Copy link
Member Author

prachi00 commented Jul 8, 2023

Screen Shot 2023-07-08 at 3 20 40 PM @exezbcz

@prury
Copy link
Member

prury commented Jul 10, 2023

Screen Shot 2023-07-08 at 3 20 40 PM @exezbcz

I believe the padding also applies to this part:
image

also: the proportion of the top and left padding also seems odd

@exezbcz
Copy link
Member

exezbcz commented Jul 10, 2023

@prury Yup, correct, it should be a divider. Please see the design

@prachi00
Copy link
Member Author

Screen Shot 2023-07-10 at 8 44 33 PM

updated

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jul 11, 2023
@prachi00
Copy link
Member Author

can me merge this one?

@prachi00 prachi00 requested a review from roiLeo July 12, 2023 22:56
@codeclimate
Copy link

codeclimate bot commented Jul 12, 2023

Code Climate has analyzed commit ed42c73 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 48694fb into main Jul 13, 2023
19 checks passed
@vikiival vikiival deleted the feat-search-alignment branch July 13, 2023 09:35
@vikiival
Copy link
Member

pay 10 usd

@yangwao
Copy link
Member

yangwao commented Jul 13, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 5.18 USD/DOT ~ 1.931 $DOT
🧗 13Qx65nLd6SwdtjrRyuoEtp9CKXhF651xdHBPaXcvhwKm4N1
🔗 0x41ca6965e588a3ca71805db05f1ff90fb02a36430ccb94efe4f893e52c1daf5d

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jul 13, 2023
This was referenced Jul 17, 2023
Merged
Merged
This was referenced Jul 25, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@vikiival vikiival vikiival approved these changes

@roiLeo roiLeo Awaiting requested review from roiLeo

Assignees
No one assigned
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search bar results alignment
8 participants
@prachi00 @kodabot @preschian @exezbcz @prury @vikiival @yangwao @roiLeo