Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Undefined account when logged out #6408

Merged
merged 1 commit into from
Jul 13, 2023
Merged

fix: Undefined account when logged out #6408

merged 1 commit into from
Jul 13, 2023

Conversation

Jarsen136
Copy link
Contributor

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

@Jarsen136 Jarsen136 requested a review from a team as a code owner July 6, 2023 15:13
@Jarsen136 Jarsen136 requested review from roiLeo and vikiival and removed request for a team July 6, 2023 15:13
@kodabot
Copy link
Collaborator

kodabot commented Jul 6, 2023

SUCCESS @Jarsen136 PR for issue #6403 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jul 6, 2023

👷 Deploy Preview for koda-canary processing.

Name Link
🔨 Latest commit 3e6e2dd
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64a6da02bd42d40008e86990

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 6, 2023

AI-Generated Summary: This pull request includes a fix for an undefined account issue when a user is logged out. A condition check has been added on authRequest.address in the setAuth function in stores/identity.ts to prevent setting 'kodaauth' to an undefined value in local storage. Now, if the authRequest.address is undefined, an empty string will be saved in local storage instead.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 6, 2023
@netlify
Copy link

netlify bot commented Jul 6, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3e6e2dd
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64a6da02bd42d40008e86990
😎 Deploy Preview https://deploy-preview-6408--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codeclimate
Copy link

codeclimate bot commented Jul 6, 2023

Code Climate has analyzed commit 3e6e2dd and detected 0 issues on this pull request.

View more on Code Climate.

roiLeo
roiLeo approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird fix but ok

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 6, 2023
@vikiival vikiival merged commit e39153c into kodadot:main Jul 13, 2023
18 of 19 checks passed
This was referenced Jul 17, 2023
Merged
Merged
This was referenced Jul 25, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@vikiival vikiival Awaiting requested review from vikiival vikiival is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined account when logged out
5 participants
@Jarsen136 @kodabot @roiLeo @vikiival @prury