Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disabled BUY button on bsx #6412

Merged
merged 3 commits into from
Jul 10, 2023
Merged

fix: Disabled BUY button on bsx #6412

merged 3 commits into from
Jul 10, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jul 9, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

  1. style on the disabled button is wired.
  1. KSM Balance does not load correctly on the bsx, so the button is always disabled.

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at ded8a70

This pull request adds support for buying NFTs with KSM on the Basilisk chain in GalleryItemBuy.vue and fixes a tooltip overflow issue in NeoTooltip.vue.

🤖 Generated by Copilot at ded8a70

urlPrefix checks
Basilisk and Kusama
Autumn NFTs

@Jarsen136 Jarsen136 requested a review from a team as a code owner July 9, 2023 09:07
@Jarsen136 Jarsen136 requested review from roiLeo and vikiival and removed request for a team July 9, 2023 09:07
@kodabot
Copy link
Collaborator

kodabot commented Jul 9, 2023

WARNING @Jarsen136 PR for issue #6309 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6309

@kodabot
Copy link
Collaborator

kodabot commented Jul 9, 2023

SUCCESS @Jarsen136 PR for issue #6411 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jul 9, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit bfe69d2
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64aa91ce4cf08300080182de
😎 Deploy Preview https://deploy-preview-6412--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 9, 2023

AI-Generated Summary: This pull request consists of two patches. The first patch modifies the NeoTooltip.vue file to fix the style of a disabled button. It changed the width property in the style when fullWidth is not true from auto to an empty string. The second patch targets the GalleryItemBuy.vue file to correct an issue with an incorrect balance on 'bsx'. Additional conditional logic was inserted to handle 'bsx' in the computation of balance. It now checks if the value of urlPrefix is 'bsx' and, if so, retrieves the native balance from the multiBalances structure in the identityStore.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 9, 2023
@Jarsen136 Jarsen136 mentioned this pull request Jul 9, 2023
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm

@codeclimate
Copy link

codeclimate bot commented Jul 9, 2023

Code Climate has analyzed commit bfe69d2 and detected 0 issues on this pull request.

View more on Code Climate.

@prury
Copy link
Member

prury commented Jul 10, 2023

@Jarsen136 it is indeed fixed for small KSM values, but strangely, even if i have:
image
the buy button still stays disabled when i try to buy NFTs with .4 .3 KSM values

10.07.2023_09.29.11_REC.mp4

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 10, 2023
@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Jul 10, 2023

@Jarsen136 it is indeed fixed for small KSM values, but strangely, even if i have: image the buy button still stays disabled when i try to buy NFTs with .4 .3 KSM values

@prury Because you are buying item on bsx network, you should check the ksm balance on the bsx. From the screenshot, I could see there is not enough ksm balance

image

@prury
Copy link
Member

prury commented Jul 10, 2023

pardon me @Jarsen136, brain defect on my side

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jul 10, 2023
@vikiival vikiival merged commit 9746959 into kodadot:main Jul 10, 2023
19 checks passed
This was referenced Jul 17, 2023
This was referenced Jul 25, 2023
This was referenced Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buy button is always disabled on basilisk item page Disabled BUY button
5 participants