Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 migrate oruga css to NeoLib #6420

Merged
merged 4 commits into from
Jul 16, 2023
Merged

🔧 migrate oruga css to NeoLib #6420

merged 4 commits into from
Jul 16, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jul 11, 2023 •
edited

Note for codereview:

  • tooltip css might be duplicated
  • table css 👍

@roiLeo roiLeo requested a review from a team as a code owner July 11, 2023 11:56
@roiLeo roiLeo requested review from vikiival and daiagi and removed request for a team July 11, 2023 11:56
@netlify
Copy link

netlify bot commented Jul 11, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit dde4d49
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64ae4f4c7cd1b60008661254
😎 Deploy Preview https://deploy-preview-6420--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 11, 2023

AI-Generated Summary: This pull request consists of two patches. The first patch migrates Oruga CSS to NeoLib. It modifies the NeoTable and NeoTooltip components, removing redundant styling from the _o-table.scss and _o-tooltip.scss files in the styles/components directory. The styles have been moved to the corresponding Vue and SCSS files in the libs/ui/src/components directory to allow for NeoLib-specific customization. The _o-table.scss and _o-tooltip.scss files are deleted as a result, and the import statements referring to these files in styles/index.scss have been removed.

The second patch changes Oruga's Carousel component to a NeoCarousel in the GalleryItem.vue component. The code has been updated to replace all instances of o-carousel and o-carousel-item with NeoCarousel and NeoCarouselItem respectively. Corresponding import statements have also been updated to reflect the changes.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Jul 11, 2023
@prury
Copy link
Member

prury commented Jul 11, 2023

readability on both tables/tool tips seems better now that the font got reduced a bit, still checking this one since there are a lot of hidden places to check

maybe a small padding is needed at the top of tables?
image

@roiLeo
Copy link
Contributor Author

roiLeo commented Jul 11, 2023

maybe a small padding is needed at the top of tables?

✅ removed padding

@prury
Copy link
Member

prury commented Jul 11, 2023

strange...
image

@codeclimate
Copy link

codeclimate bot commented Jul 12, 2023

Code Climate has analyzed commit dde4d49 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo
Copy link
Contributor Author

roiLeo commented Jul 12, 2023

strange...

Idk what happened this is external to my modifications but know it work

@prury
Copy link
Member

prury commented Jul 12, 2023

strange...

Idk what happened this is external to my modifications but know it work

i know i know

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 12, 2023
@vikiival
Copy link
Member

Screenshot 2023-07-14 at 13 41 17

Looks like it works now

vikiival
vikiival approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO

@vikiival vikiival enabled auto-merge (squash) July 16, 2023 08:23
@vikiival vikiival disabled auto-merge July 16, 2023 08:24
@vikiival vikiival merged commit ca44fab into kodadot:main Jul 16, 2023
19 checks passed
This was referenced Jul 17, 2023
Merged
Merged
This was referenced Jul 25, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
medium Pull request is medium S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate oruga component from kodadot
3 participants
@roiLeo @prury @vikiival