Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 migrate Buefy buttons #6437

Merged
merged 4 commits into from
Jul 20, 2023
Merged

🔧 migrate Buefy buttons #6437

merged 4 commits into from
Jul 20, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jul 18, 2023

@roiLeo roiLeo requested a review from a team as a code owner July 18, 2023 07:05
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team July 18, 2023 07:05
@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 7789c35
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64b91d0ce1db120008bdbb7e
😎 Deploy Preview https://deploy-preview-6437--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 18, 2023

AI-Generated Summary: This pull request updates a Vue.js project to switch from the Buefy UI library's button tags to a new custom NeoButton component. This offers a more consistent and controlled aesthetic across the application. The changes include adjustments in property names and event binding behaviours and it impacts 12 files including components related to Offers, Search, Gallery, and Create features of the app. The NeoButton component is now also added in imported components relevant to these features. The patch also includes a few changes in applied CSS classes, component replacement in the Search.vue, and some logic adjustments for range in SearchPriceRange.vue. All instances of have been altered to and the corresponding attribute changes have been made.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Jul 18, 2023
@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jul 18, 2023
@roiLeo roiLeo mentioned this pull request Jul 18, 2023
37 tasks
@prury
Copy link
Member

prury commented Jul 18, 2023

RMRK -> attributes: huge x
image

@roiLeo this emoji reaction thing and the price chart zoom are disabled/not being used, right?

unrelated: spotlight dice button #6439

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 18, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 18, 2023

Code Climate has analyzed commit b23263f and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo
Copy link
Contributor Author

roiLeo commented Jul 18, 2023

@prury
Copy link
Member

prury commented Jul 18, 2023

thank you!

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jul 18, 2023
@roiLeo
Copy link
Contributor Author

roiLeo commented Jul 20, 2023

🚀 lmk if something break afterward

@roiLeo roiLeo merged commit 17ec55a into kodadot:main Jul 20, 2023
5 of 8 checks passed
This was referenced Jul 25, 2023
@yangwao yangwao mentioned this pull request Aug 2, 2023
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attribute x icon aligment random page button on spotlight page
4 participants