Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Statemine properties not showing #6438

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jul 18, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

/stmn/gallery/3-1

image

Copilot Summary

🤖 Generated by Copilot at 57c6b3b

This pull request fixes a bug in displaying NFT attributes and updates the stick indexer URL to use the latest version. It modifies useNft.ts, indexers.ts, nftById.graphql, and constants.ts to handle the new NFT attributes format.

🤖 Generated by Copilot at 57c6b3b

stick indexer v4
fixes NFT attributes
fall is for bug squash

@Jarsen136 Jarsen136 requested a review from a team as a code owner July 18, 2023 12:18
@Jarsen136 Jarsen136 requested review from roiLeo and daiagi and removed request for a team July 18, 2023 12:18
@kodabot
Copy link
Collaborator

kodabot commented Jul 18, 2023

SUCCESS @Jarsen136 PR for issue #6426 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 41740b9
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64b6aad10c0bb50007d85290
😎 Deploy Preview https://deploy-preview-6438--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 18, 2023

AI-Generated Summary: This pull request provides a fix for the issue where Statemine properties were not displaying. This is accomplished by modifying four files - useNft.ts, indexers.ts, nftById.graphql, and constants.ts.

The changes include updating indexer stmn and stick URLs from v3 to v4 in indexers.ts and constants.ts files. These updates are presumably to use the latest version of the endpoint. In useNft.ts, the getter for attr has been changed to give priority to nft?.attributes over nft?.meta?.attributes, this will ensure that attributes are properly pulled and displayed.

The nftById.graphql file has also been updated to include the retrieval of attributes { key: trait, value }, which would allow the NFT attributes to be fetched when an NFT is queried by its ID. These changes overall aim to appropriately retrieve and display Statemine properties, enabling a better user experience.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 18, 2023
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on https://deploy-preview-6438--koda-canary.netlify.app/stmn/gallery/9-231

✅ code lgtm

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jul 18, 2023
composables/useNft.ts Outdated Show resolved Hide resolved
@vikiival
Copy link
Member

Otherwise LGTM

@prury
Copy link
Member

prury commented Jul 18, 2023

once this is merged, I'll be opening another issue for this:
image
https://deploy-preview-6438--koda-canary.netlify.app/stmn/gallery/9-143

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 18, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 18, 2023

Code Climate has analyzed commit 41740b9 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@vikiival vikiival merged commit dc5a609 into kodadot:main Jul 19, 2023
18 of 19 checks passed
@vikiival
Copy link
Member

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Jul 19, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 5.15 USD/DOT ~ 3.883 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0xad9080282965edd220ccb252ecb1b1d7c63779c14bbb29373de6a65c0b2e89ba

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jul 19, 2023
This was referenced Jul 25, 2023
This was referenced Aug 2, 2023
@yangwao yangwao mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statemine properties not showing
6 participants