Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 mobile activity table border none #6447

Merged
merged 2 commits into from
Jul 20, 2023
Merged

🔧 mobile activity table border none #6447

merged 2 commits into from
Jul 20, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jul 20, 2023

@roiLeo roiLeo requested a review from a team as a code owner July 20, 2023 09:46
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team July 20, 2023 09:46
@netlify
Copy link

netlify bot commented Jul 20, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 85dd775
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64b918a4269d4400080c1542
😎 Deploy Preview https://deploy-preview-6447--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 20, 2023

AI-Generated Summary: This pull request includes changes related to code organization and mobile responsive design. The modifications primarily involve:

  1. In the GalleryItemActivityTable.vue, there are additional styling rules added specifically for mobile display, altering the border-bottom property of table data elements.
  2. In Sharing.vue and massMint Helpers.ts files, the relative import statements have been refactored to use absolute paths, making the code more readable and maintainable.
  3. The same refactoring has also been done in the useMassMint.ts file, where an import statement has been switched from a relative to an absolute path.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 20, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 20, 2023

Code Climate has analyzed commit e3b7dba and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jul 20, 2023
@roiLeo roiLeo merged commit 6087f45 into kodadot:main Jul 20, 2023
1 check was pending
@roiLeo roiLeo deleted the fix/mobile/activity-table branch July 20, 2023 11:21
This was referenced Jul 25, 2023
Merged
Merged
Merged
Merged
This was referenced Aug 2, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Activity sections styling
3 participants
@roiLeo @preschian @Jarsen136