Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuxt-property-decorator/Transfer #6456

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Jul 22, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Pages in this PR

/prefix/transfer

desired outcome

no change in look and/or behavior

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at 825b84f

Added block explorer support and improved Auth component. The useChain composable can now provide a blockExplorer link for different chains, and the Auth component can be used without specifying a size prop.

🤖 Generated by Copilot at 825b84f

We're sailing on the web with our Auth component
We've made the size prop optional, so it's more convenient
And when we need to check the chain, we have a handy link
We use the blockExplorer to see what's on the brink

@daiagi daiagi requested a review from a team as a code owner July 22, 2023 04:36
@daiagi daiagi requested review from preschian and Jarsen136 and removed request for a team July 22, 2023 04:36
@netlify
Copy link

netlify bot commented Jul 22, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 825b84f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64bb5ce88e3ef000085663e9
😎 Deploy Preview https://deploy-preview-6456--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codeclimate
Copy link

codeclimate bot commented Jul 22, 2023

Code Climate has analyzed commit 825b84f and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 22, 2023

AI-Generated Summary: This pull request introduces several changes across both TypeScript and Vue.js files.

In the TypeScript file useChain.ts, a new constant blockExplorer is added inside the default exported function. This is then returned from the function, thereby expanding its return object to now include blockExplorer.

In the Auth.vue file in the shared components directory, a minor modification is made where the 'size' property in the defineProps function has been changed from mandatory to optional.

The Vue.js codebase sees a significant simplification in the transfer page. Code related to state and logic management for blockchain-related interactions has been stripped out, implying a move towards more centralized state management. This includes the introduction of a new Transfer component that handles a host of operations - from fetching fiat prices to handling transaction submissions.

Specifically, the Transfer.vue component, a major addition, enhances the application's functionalities and user interactions. The component includes a rich user interface, complete with status indicators, linkages to artist profiles, balance displays, input fields, and necessary buttons for various interactions such as submitting transactions and sharing via twitter.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Jul 22, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 22, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 23, 2023
@yangwao
Copy link
Member

yangwao commented Jul 25, 2023

pay 50 usd

@yangwao yangwao merged commit 62174ea into main Jul 25, 2023
20 checks passed
@yangwao yangwao deleted the nuxt-property-decorator/Transfer branch July 25, 2023 15:01
@yangwao
Copy link
Member

yangwao commented Jul 25, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 5.14 USD/DOT ~ 9.728 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0x5c4505199449d3edea9058033734cf0cd549628eee8be76d184fcefc2215462e

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jul 25, 2023
This was referenced Jul 25, 2023
@roiLeo
Copy link
Contributor

roiLeo commented Jul 31, 2023

☹️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants