Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: KodaDot blog #6461

Merged
merged 4 commits into from
Jul 25, 2023
Merged

feat: KodaDot blog #6461

merged 4 commits into from
Jul 25, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Jul 24, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs Design check

Context

Screenshot 📸

  • My fix has changed UI

Screenshot 2023-07-24 163223
Screenshot 2023-07-24 163208

Copilot Summary

🤖 Generated by Copilot at b46e2e6

This pull request adds a blog feature to the NFT gallery website, using markdown files as the source of content. It introduces a new module for loading markdown files as Vue components, and updates some dependencies to improve performance and compatibility. It also adds some components and pages for rendering the blog posts and the blog index, and some markdown files for the blog content.

🤖 Generated by Copilot at b46e2e6

We write the content in markdown
We load it with frontmatter
We render the blog with Vue
We set the meta for SEO

@kodabot
Copy link
Collaborator

kodabot commented Jul 24, 2023

WARNING @preschian PR for issue #6419 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6419

@kodabot
Copy link
Collaborator

kodabot commented Jul 24, 2023

WARNING @preschian PR for issue #6432 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6432

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 561903f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64bfaed30b3a440008d6756d
😎 Deploy Preview https://deploy-preview-6461--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 24, 2023

AI-Generated Summary: This pull request involves comprehensive modifications to the project, primarily aimed at revamping the blog functionality.

  1. The file first-time.vue was removed, stipulating possible removal of exclusively associated components.
  2. Changes were made to package.json, adding frontmatter-markdown-loader and removing raw-loader.
  3. Edits made to nuxt.config.js involve the configuration update for the markdown file loader, replacing 'raw-loader' with 'frontmatter-markdown-loader', with additional options for the new loader.
  4. A new blog post discussing the ERC6551 token and its interaction with the Ethereum blockchain was added titled what-is-erc6551.md.
  5. A new Vue.js component, BlogPost.vue, was created, set up with various templates and functions for handling blog posts' metadata and layout.
  6. A new index file under pages/blog was created featuring blog posts in cards view, with functionalities to load blog posts content asynchronously and generate permalinks for individual blog posts, styled to design the blog's visual aesthetics.
  7. Lastly, a file blog/_slug.vue was created, where the BlogPost component was added providing a way to generate dynamic routes depending on blog post slugs.

Overall, the pull request aims to improve the project's blog feature set, making it more dynamic, user-friendly, and feature-loaded while optimizing dependencies.

@reviewpad reviewpad bot added the large Pull request is large label Jul 24, 2023
@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
frontmatter-markdown-loader 3.7.0 environment +1 23.2 kB hmsk

🚮 Removed packages: raw-loader@4.0.2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it safe to remove this component? I couldn't find the entry point to visit this page

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would check readme of this repo or hello.kodadot.xyz

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like no page linked to kodadot.xyz/first-time https://github.com/search?q=org%3Akodadot%20first-time&type=code
CMIIW

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so for now! We will remake it to blog in new form I bet.

@preschian preschian marked this pull request as ready for review July 24, 2023 09:43
@preschian preschian requested a review from a team as a code owner July 24, 2023 09:43
@preschian preschian requested review from vikiival and daiagi and removed request for a team July 24, 2023 09:43
@preschian preschian requested a review from roiLeo July 24, 2023 09:44
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would check readme of this repo or hello.kodadot.xyz

@prury
Copy link
Member

prury commented Jul 24, 2023

  • white text on dark mode:
  • i think this part of the text should not be bold
  • mobile looking good

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 24, 2023
@exezbcz
Copy link
Member

exezbcz commented Jul 24, 2023

Hello, hello, nice job!

Few things:

Landing

image

  • there is line separating the img and the rest

image

  • this size 16px, please - I have updated the component there
    image

heading of the article to 31px
image

  • good job with the mobile version! 👍

single blog

image

  • subtitle to 25px, regular weight
    image
  • paragraph text to 20px, line height 30px, color accentlight2 dark (grey shade of pink) - #363234
  • round img with stroke on this page as well
    image

dark mode

  • sorry that I left it out. Here it is
    image
  • updated in the handoff file

thanks!

@codeclimate
Copy link

codeclimate bot commented Jul 25, 2023

Code Climate has analyzed commit 561903f and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Jul 25, 2023

I guess so for now!
We will remake it to blog in new form, for general onboarding article for developers

https://kodadot.xyz/first-time/

@yangwao
Copy link
Member

yangwao commented Jul 25, 2023

once this merged, this would be good to release

@yangwao
Copy link
Member

yangwao commented Jul 25, 2023

I've got approval from @exezbcz and will do another round as we need surf erc6551

@yangwao yangwao merged commit f4ab9c1 into main Jul 25, 2023
19 checks passed
@yangwao yangwao deleted the feat/blog-post branch July 25, 2023 15:01
@yangwao yangwao mentioned this pull request Jul 25, 2023
This was referenced Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large S-changes-requested-🤞 PR is almost good to go, just some fine tunning waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Blogpost] What is ERC6551 - Token Bound Accounts (TBA) ? Blog template and few posts
6 participants