-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer Redesign handover - (1) Desktop design #6486
Conversation
WARNING @Jarsen136 PR for issue #6464 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6464 |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request introduces a major overhaul of the A new There is also an addition of a new calculation function Lastly, a fresh block of English translations related to transfers was added to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daiagi Thanks for your comment. I have updated them. Could you pls review again ?
As @prury mentioned, there is no delete button once you add a recipient, I think it was written somewhere that it's intentionally? |
Pending problems from Exez image: for the other ones I've found i will open another issue |
Fixed |
it works, but is still buggy, will add to #6529 |
yup, works for me, good job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would merge it if so, we will be doing plenty of follow-ups, no worries 😄 |
Code Climate has analyzed commit ff787c3 and detected 0 issues on this pull request. View more on Code Climate. |
It's not related to this PR. There seems some magic in the preview environment. The account balance on stmn network could not be fetched correctly on the env. I found the bug also appeals in other preview env. for example https://deploy-preview-6501--koda-canary.netlify.app/stmn/transfer On canary env the bug is disappear. |
pay 50 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs Design check
Context
Did your issue had any of the "$" label on it?
Screenshot 📸
/dot/transfer?redesign=true
/ksm/transfer?redesign=true
Copilot Summary
🤖 Generated by Copilot at d2c862a
This pull request introduces a new version of the
Transfer
component, which allows users to send NFTs to multiple recipients, choose different units, and generate a pay me link. The new component is styled with CSS and has English translations. A feature flag is added to switch between the new and old versions of the transfer page. A utility function is added to convert balance values to USD.🤖 Generated by Copilot at d2c862a