Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blogpost] The Rise of Onchain NFTs: Shaping the Future of Digital Collectibles #6500

Merged
merged 7 commits into from
Aug 2, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jul 31, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

/blog/shaping-the-future-of-digital-collectibles

Did your issue had any of the "$" label on it?

Copilot Summary

🤖 Generated by Copilot at 7a20599

This pull request adds a new blog post about onchain NFTs and improves the blog index page. The post introduces the concept and features of onchain NFTs, and showcases some examples of projects using them. The index page fixes the URL generation and adds some styling to the content list.

🤖 Generated by Copilot at 7a20599

Sing, O Muse, of the skillful coder who devised
A wondrous blog post on the onchain NFTs,
The new-born digital collectibles that reside
On the blockchain, storing both the form and the keys.

@Jarsen136 Jarsen136 requested a review from a team as a code owner July 31, 2023 03:39
@Jarsen136 Jarsen136 requested review from roiLeo and vikiival and removed request for a team July 31, 2023 03:39
@kodabot
Copy link
Collaborator

kodabot commented Jul 31, 2023

SUCCESS @Jarsen136 PR for issue #6498 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 346bc83
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64c9d70ac3d00c0008b9fa4d
😎 Deploy Preview https://deploy-preview-6500--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 31, 2023

AI-Generated Summary: This pull request introduces a new blog post titled "The Rise of Onchain NFTs: Shaping the Future of Digital Collectibles". The blog post provides an in-depth overview of non-fungible tokens (NFTs), explaining their fundamental characteristics, their limitations, and how onchain NFTs can address these challenges. It also introduces some notable onchain NFT projects and discusses the future of onchain NFTs.

In addition to the new blog entry, this PR modifies some styling elements on the blog index page. It includes more spacing between the list of blog post entries and contains changes for better image handling, including adding a maximum height and preventing overflow.

Lastly, the PR includes a new image related to the newly added blog titled "shaping-the-future-of-digital-collectibles-1.png".

@JustLuuuu
Copy link
Member

JustLuuuu commented Jul 31, 2023

Please rename all onchain NFTs to on-chain NFTs in the text and in the headlines. We are missing the dash "-".🚀 Besides that, it's good to go.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capture d’écran 2023-07-31 à 11 00 05 AM

☹️ inb4 seo blacklist

@Jarsen136
Copy link
Contributor Author

Please rename all onchain NFTs to on-chain NFTs in the text and in the headlines. We are missing the dash "-".🚀 Besides that, it's good to go.

✅ Done

@prury
Copy link
Member

prury commented Jul 31, 2023

spacing:

image

spacing and bold on the collections title:

image

it somehow affected the other article:

image

mobile seems ok

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 31, 2023
@yangwao
Copy link
Member

yangwao commented Aug 1, 2023

pay 50 usd

Let's resolve conflicts @Jarsen136 and it's good to merge so we can push it out live 🙏🔥

@yangwao
Copy link
Member

yangwao commented Aug 1, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 5.11 USD/DOT ~ 9.785 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x3bc63c82794f402a2ecc331dc306e3da76808ca07c675c2aaf12700d4395e526

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 1, 2023
@Jarsen136
Copy link
Contributor Author

also close this issue #6509 (comment)

image

@Jarsen136
Copy link
Contributor Author

spacing and bold on the collections title:

image

@prury I'm not sure if it's related to Windows OS or not, but I could not reproduce the bold text issue you mentioned. It's a h3 title with bold font weight on my side.
image

@codeclimate
Copy link

codeclimate bot commented Aug 2, 2023

Code Climate has analyzed commit 346bc83 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao yangwao disabled auto-merge August 2, 2023 09:08
@yangwao yangwao merged commit 2a3c35a into kodadot:main Aug 2, 2023
19 checks passed
This was referenced Aug 2, 2023
@prury
Copy link
Member

prury commented Aug 2, 2023

@prury I'm not sure if it's related to Windows OS or not, but I could not reproduce the bold text issue you mentioned. It's a h3 title with bold font weight on my side. image

aww thats odd, allright! thank you

This was referenced Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-changes-requested-🤞 PR is almost good to go, just some fine tunning small Pull request is small waiting-for-review
Projects
None yet
7 participants