Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 blog page refacto #6505

Merged
merged 1 commit into from
Jul 31, 2023
Merged

🔧 blog page refacto #6505

merged 1 commit into from
Jul 31, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jul 31, 2023

could be related with #6474

  • fix main title
  • fix hero-card tag color
  • fix hero-card title line-height
  • truncate card text
  • fix some sizes

Screenshot 2023-07-31 at 14-57-20 KodaDot - NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner July 31, 2023 12:57
@roiLeo roiLeo requested review from preschian and vikiival and removed request for a team July 31, 2023 12:57
@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ae50dc1
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64c7afc64fb51300088c2f0e
😎 Deploy Preview https://deploy-preview-6505--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 31, 2023

AI-Generated Summary: This pull request contains refactoring changes for the blog page. The patch introduced 59 insertions and 19 deletions from the blog index file with multiple updates. It updates the style and layout, for example, the 'KodaDot Blog' headline and subtitle section have been updated with new CSS classes for better stylization and alignment. It also introduces a new 'hero-card' div which contains image thumbnails for blog posts, the post title, and a subtitle. A key change is to the existing for loop used to display blog posts. The post's title, tag, and subtitle now carry specific CSS classes for better design control. Styling attributes have been updated throughout for more precise control over font sizes, weights, and colors. The permalink structure has been edited, and a View Article button has been added to each post. Lastly, significant CSS updates for different sections in the index file have been made.

@codeclimate
Copy link

codeclimate bot commented Jul 31, 2023

Code Climate has analyzed commit ae50dc1 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 31, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 31, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@vikiival
Copy link
Member

@prury if this looks good happy to merge

@prury
Copy link
Member

prury commented Jul 31, 2023

@prury if this looks good happy to merge

Lemme check, just a moment

@prury
Copy link
Member

prury commented Jul 31, 2023

it works for this specific blog post, but i do want to see how the other posts will behave using these same CSS settings, lets merge and see? maybe we will need to truncate the title as well later on and mess with the images

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 31, 2023
@vikiival
Copy link
Member

lets merge and see

@vikiival vikiival merged commit 87f4bba into kodadot:main Jul 31, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants