Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use new gen formats for blog assets #6516

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Aug 2, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

file size change
image

Did your issue had any of the "$" label on it?

Copilot Summary

🤖 Generated by Copilot at 5863fc8

The pull request updates the image file extensions of two blog posts, revolutionizing-digital-ownership.md and shaping-the-future-of-digital-collectibles.md, from .png to .webp to improve the web page performance. No other content changes were made.

🤖 Generated by Copilot at 5863fc8

Sing, O Muse, of the swift and skillful coder
Who changed the image files with cunning art
From .png to .webp, the lighter loader
That speeds the web page like a flying dart

@Jarsen136 Jarsen136 requested a review from a team as a code owner August 2, 2023 11:17
@Jarsen136 Jarsen136 requested review from roiLeo and vikiival and removed request for a team August 2, 2023 11:17
@kodabot
Copy link
Collaborator

kodabot commented Aug 2, 2023

SUCCESS @Jarsen136 PR for issue #6511 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 82913ad
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64ca4ece8b59090008eaee66
😎 Deploy Preview https://deploy-preview-6516--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 2, 2023

AI-Generated Summary: This pull request mainly includes changes in blog content associated with image file formats. PNG image file references in two blog posts, "Dynamic NFTs: Revolutionizing Digital Ownership" and "The Rise of On-Chain NFTs: Shaping the Future of Digital Collectibles" are replaced with corresponding WEBP file versions. Changes are made in the metadata of the blog posts as well as source attributes in the HTML image tags within the blog content. There are corresponding changes in the static/blog directory with deletion of PNG files and addition of WEBP files, emphasizing the transition from PNG to WEBP. There is also a minor correction in the markdown file of "Dynamic NFTs: Revolutionizing Digital Ownership" post for maintaining consistent formatting and to ensure there exists a newline at the end of the file.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 2, 2023
@vikiival
Copy link
Member

vikiival commented Aug 2, 2023

Fit repo

@prury
Copy link
Member

prury commented Aug 2, 2023

@Jarsen136 could you also please convert this one?

image

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Aug 2, 2023

@Jarsen136 could you also please convert this one?

image

It's an external image though. I will convert its format and put it in our code repository

https://eips.ethereum.org/assets/eip-6551/diagram.png

image

@prury
Copy link
Member

prury commented Aug 2, 2023

It's an external image though. I will convert its format and put it in our code repository

true, thank you!

@Jarsen136
Copy link
Contributor Author

✅ Done

@codeclimate
Copy link

codeclimate bot commented Aug 2, 2023

Code Climate has analyzed commit 82913ad and detected 0 issues on this pull request.

View more on Code Climate.

@prury
Copy link
Member

prury commented Aug 2, 2023

✅ Done

i appreciate!

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 2, 2023
@vikiival vikiival merged commit c15e539 into kodadot:main Aug 2, 2023
19 checks passed
This was referenced Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new gen formats for blog assets
5 participants