Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker setup is not working #6531

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Docker setup is not working #6531

merged 1 commit into from
Aug 4, 2023

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Aug 4, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Specifying the pnpm version fixes the issue and the docker environment runs as expected

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

CleanShot 2023-08-04 at 10 12 31@2x

Copilot Summary

🤖 Generated by Copilot at cd1c7ab

Updated Dockerfile to use the same pnpm version as package.json. This improves the build consistency and reliability.

🤖 Generated by Copilot at cd1c7ab

PNPM_VERSION set
Docker and local match well
A stable winter

@hassnian hassnian requested a review from a team as a code owner August 4, 2023 04:47
@hassnian hassnian requested review from preschian and roiLeo and removed request for a team August 4, 2023 04:47
@kodabot
Copy link
Collaborator

kodabot commented Aug 4, 2023

SUCCESS @hassnian PR for issue #6428 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit cd1c7ab
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64cc8300acd4700008bdb0b0
😎 Deploy Preview https://deploy-preview-6531--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 4, 2023

AI-Generated Summary: This pull request includes changes to the Dockerfile to fix an issue with the 'pnpm install' command not running correctly. The patch suggests setting the same pnpm version as the one specified in the package.json. To achieve this, the contributor introduced a new environment variable PNPM_VERSION and modified the 'npm install' line to ensure that this specific version of pnpm is installed globally.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 4, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 4, 2023

Code Climate has analyzed commit cd1c7ab and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, didnt tested it yet

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 4, 2023
@yangwao
Copy link
Member

yangwao commented Aug 4, 2023

pay 30 usd

@yangwao yangwao merged commit 0035df9 into kodadot:main Aug 4, 2023
20 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 4, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.99 USD/DOT ~ 6.012 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0xb7a20a1c19a477ccab74dc752374fd27f259ae86fe2f8afd15cd1bd47b0deb13

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 4, 2023
This was referenced Aug 5, 2023
@hassnian hassnian deleted the issue-6428 branch August 6, 2023 12:18
This was referenced Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker setup is not working
4 participants