Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change URL slug of blogs Onchain nfts and Dynamic nfts #6557

Merged
merged 2 commits into from
Aug 5, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Aug 5, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

Copilot Summary

🤖 Generated by Copilot at f737fd2

Renamed some blog posts to include more descriptive and relevant keywords in their titles. This improves SEO and helps readers find the content they are looking for.

🤖 Generated by Copilot at f737fd2

is_valid checks
refactored for clarity
autumn leaves falling

@Jarsen136 Jarsen136 requested a review from a team as a code owner August 5, 2023 14:04
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team August 5, 2023 14:04
@kodabot
Copy link
Collaborator

kodabot commented Aug 5, 2023

SUCCESS @Jarsen136 PR for issue #6556 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 5, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3b47257
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64ce587eb5175f0008ba1050
😎 Deploy Preview https://deploy-preview-6557--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 5, 2023

AI-Generated Summary: This pull request includes changes to the filenames of three blog posts, with no insertion or deletion of content. The renaming is aimed at making the URL slugs more informative. The file revolutionizing-digital-ownership.md is renamed to dynamic-nfts-revolutionizing-digital-ownership.md. Likewise, shaping-the-future-of-digital-collectibles.md is changed to the-rise-of-onchain-nfts-shaping-the-future-of-digital-collectibles.md. And finally, what-is-erc6551.md is now what-is-erc6551-token-bound-accounts.md. This renaming is made to better reflect the contents of each blog post.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review docs labels Aug 5, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 5, 2023

Code Climate has analyzed commit 3b47257 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 5, 2023
@yangwao
Copy link
Member

yangwao commented Aug 5, 2023

pay 50 usd

@yangwao yangwao merged commit 24c7799 into kodadot:main Aug 5, 2023
16 of 20 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 5, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.93 USD/DOT ~ 10.142 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x2a8280d69c3533a0ce30d53df2684feffd6f03dfff6ba6cc41fc8371f4123824

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change URL slug of blogs Onchain nfts and Dynamic nfts Page reload when clicking on view article
4 participants