Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After minting, user does not get redirect to NFT and Error when trying to massmint on RMRK2 #6570

Merged
merged 3 commits into from
Aug 6, 2023

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Aug 6, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI;

Copilot Summary

🤖 Generated by Copilot at d0045a1

This pull request enables minting NFTs without listing them for sale, and improves the compatibility and validity of the arguments for the batched minting transactions. It refactors the CreateToken component and the transactionMintRmrk composable.

🤖 Generated by Copilot at d0045a1

Sing, O Muse, of the crafty code that the heroes wrought
To mint new tokens of their art, with skill and cunning fraught
They filtered out the false and wrapped the args in system.remark
To execute a batch of transactions, swift and smooth as a shark

@hassnian hassnian requested a review from a team as a code owner August 6, 2023 05:59
@hassnian hassnian requested review from roiLeo and Jarsen136 and removed request for a team August 6, 2023 05:59
@kodabot
Copy link
Collaborator

kodabot commented Aug 6, 2023

WARNING @hassnian PR for issue #6508 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6508

@netlify
Copy link

netlify bot commented Aug 6, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 42585bb
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64cf8d62c47d820008d76853
😎 Deploy Preview https://deploy-preview-6570--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Aug 6, 2023

SUCCESS @hassnian PR for issue #6526 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 6, 2023

AI-Generated Summary: This pull request contains two patches that fix issues related to Non-Fungible Token (NFT) operations.

The first part of the changes addresses a problem where the application was failing to redirect after a simple NFT mint operation. The solution includes code rearrangements and an introduction of handleCreatedNftsRedirect method to handle redirection after the NFT creation.

The second part of the patches resolves an error that was occurring when trying to perform mass minting. The fix optimizes the argument handling for the execMintRmrk function, specifically for batch transaction cases. The arguments are pre-filtered and transformed before being passed for execution.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 6, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 6, 2023

Code Climate has analyzed commit 42585bb and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prury
Copy link
Member

prury commented Aug 6, 2023

RMRK2
Classic minting redirection - ✔️
Massmint redirection - ✔️
Massmint process: ✔️
https://kusama.subscan.io/tx/0x89e4c54c91b3704f553ac4900153787080a4f221374ec4f9245869a01d49fd02
massminted NFTs: https://deploy-preview-6570--koda-canary.netlify.app/ksm/collection/7EA1DCF47E98A25067-RPG

RMRK1
Classic minting redirection - ✔️
Simple minting redirection - ✔️
Massmint redirection - ✔️

Tester account:
https://kusama.subscan.io/account/FSMdmCLv5gFZ87YerB3M8ZSQ58BGHdSnreC4J6znWpqPQK9

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 6, 2023
@yangwao
Copy link
Member

yangwao commented Aug 6, 2023

pay 70 usd

@yangwao yangwao merged commit 2898ccc into kodadot:main Aug 6, 2023
15 of 20 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 6, 2023

😍 Perfect, I’ve sent the payout
💵 $70 @ 4.98 USD/DOT ~ 14.056 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0x89b242924559dc53209c2fdf872b0ff4b1ee0a9b3edf2e5626cac82ae86097a7

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 6, 2023
This was referenced Aug 6, 2023
@hassnian hassnian deleted the issue-6526 branch August 7, 2023 02:42
This was referenced Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After minting, user does not get redirect to NFT Error when trying to massmint on RMRK2
6 participants