Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ParaSpell XCM SDK #6573

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Update ParaSpell XCM SDK #6573

merged 2 commits into from
Aug 7, 2023

Conversation

dudo50
Copy link
Contributor

@dudo50 dudo50 commented Aug 6, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Not eligible

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 0b38eb5

This pull request updates the @paraspell/sdk dependency to the latest version and refactors the token formatting logic in the Teleport component. These changes improve the user experience and reliability of the NFT gallery.

🤖 Generated by Copilot at 0b38eb5

To teleport tokens with ease
We updated the @paraspell/sdk
And some @polkadot stuff
That required a build, not a bluff
And removed the currency formatting for KSM

- This commit updates XCM SDK version from 1.1.15 -> 2.0.5 & resolves small breaking change in teleport.
@dudo50 dudo50 requested a review from a team as a code owner August 6, 2023 12:36
@dudo50 dudo50 requested review from roiLeo and vikiival and removed request for a team August 6, 2023 12:36
@kodabot
Copy link
Collaborator

kodabot commented Aug 6, 2023

WARNING @dudo50 PR for issue #4925 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4925

@kodabot
Copy link
Collaborator

kodabot commented Aug 6, 2023

WARNING @dudo50 PR for issue #5497 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5497

@netlify
Copy link

netlify bot commented Aug 6, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d0456be
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64d08f0b82d10d00082a9d3b
😎 Deploy Preview https://deploy-preview-6573--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Aug 6, 2023

WARNING @dudo50 PR for issue #5597 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5597

@kodabot
Copy link
Collaborator

kodabot commented Aug 6, 2023

WARNING @dudo50 PR for issue #6431 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6431

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 6, 2023

AI-Generated Summary: This pull request updates the ParaSpell XCM SDK from version 1.1.15 to 2.0.5 in the project. It modifies three files: Teleport.vue, package.json, and pnpm-lock.yaml. In Teleport.vue, the currency specification for transaction building is removed. In package.json and pnpm-lock.yaml, the references to the old SDK version are replaced with the new one. Additionally, the lockfile version in pnpm-lock.yaml is downgraded from '6.1' to '6.0'. A breaking change regarding the teleport component has been resolved.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 6, 2023
@dudo50
Copy link
Contributor Author

dudo50 commented Aug 6, 2023

@yangwao PR should be formatted correctly now.

@roiLeo roiLeo requested a review from prury August 6, 2023 14:53
components/teleport/Teleport.vue Show resolved Hide resolved
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 7, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 7, 2023

Code Climate has analyzed commit d0456be and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vikiival
Copy link
Member

vikiival commented Aug 7, 2023

I re-ran all cypress tests.
happy to merge after

Btw @dudo50 have you tested teleport or so if it works?

@dudo50
Copy link
Contributor Author

dudo50 commented Aug 7, 2023

I re-ran all cypress tests. happy to merge after

Btw @dudo50 have you tested teleport or so if it works?

Hi @vikiival, yes all scenarios are tested on the localhost build of Kodadot. They work as expected and so the update resolved everything as we advised a while ago in a previous issue that suggested updating to v2.0.5.

Just a couple of things I noticed and will open an issue about them soon so you can enhance the user experience a bit further:

  • When a user clicks MAX token amount to transfer transaction fails because there is nothing to pay fees with on the origin chain. Max should be a bit less than the actual amount of tokens the user holds
  • The new balances after transfer take a while to appear and usually appear after refresh of the page only (For me, this might not be issue on other PCs)

Here is a list of test transactions:
Kusama <> Basilisk
https://kusama.subscan.io/extrinsic/19128878-5
https://basilisk.subscan.io/extrinsic/3943633-2
Kusama <> Statemine
https://kusama.subscan.io/extrinsic/19128886-5
https://assethub-kusama.subscan.io/extrinsic/5085629-2

@vikiival
Copy link
Member

vikiival commented Aug 7, 2023

will open an issue about them soon so you can enhance the user experience a bit further:

Yes, please do ^-^

@vikiival vikiival merged commit 5755d4d into kodadot:main Aug 7, 2023
16 of 20 checks passed
This was referenced Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
4 participants