Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 select collection on create nft page #6582

Merged
merged 1 commit into from
Aug 6, 2023
Merged

🔧 select collection on create nft page #6582

merged 1 commit into from
Aug 6, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Aug 6, 2023 •
edited

  • rewritte CollectionSelect vue3 composition api
  • fix message label on select
  • fix emit event

Screenshot

before
Screenshot 2023-08-06 at 17-34-42 KodaDot Low fees and low carbon minting KodaDot - NFT Market Explorer

after
Screenshot 2023-08-06 at 16-23-29 KodaDot Low fees and low carbon minting KodaDot - NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner August 6, 2023 15:35
@roiLeo roiLeo requested review from vikiival and Jarsen136 and removed request for a team August 6, 2023 15:35
@netlify
Copy link

netlify bot commented Aug 6, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit afa708d
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64cfbdd1acd47000089e3ee6
😎 Deploy Preview https://deploy-preview-6582--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 6, 2023

AI-Generated Summary: This pull request titled "Select collection on create nft page" includes changes to two files: BaseTokenForm.vue and CollectionSelect.vue.
In BaseTokenForm.vue, the 'vSelectedCollection' model is changed from a direct data binding to a method-driven model, allowing the selected collection to be set via a method 'onCollectionSelected'.
In CollectionSelect.vue, the structure is refactored. It moved to using Vue3's composition API with the script setup tag. Also, a watcher is added to emit 'changeSelectedCollection' whenever the selected collection value changes.

@reviewpad reviewpad bot added the small Pull request is small label Aug 6, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 6, 2023

Code Climate has analyzed commit afa708d and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 6, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud
Copy link

sonarcloud bot commented Aug 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

@yangwao yangwao merged commit 92f2647 into kodadot:main Aug 6, 2023
16 of 20 checks passed
This was referenced Aug 6, 2023
Merged
Merged
@roiLeo roiLeo deleted the fix/create/nft branch August 7, 2023 06:25
This was referenced Aug 8, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival Awaiting requested review from vikiival vikiival is a code owner automatically assigned from kodadot/code-review-guild

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roiLeo @yangwao