Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 ProfileLink, ScrollTopButton, HotTable & SalesTable #6594

Merged
merged 7 commits into from
Aug 8, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Aug 7, 2023

edit:

  • updated page subtitle to display current chain
    Screenshot 2023-08-07 at 19-49-36 Recently KUSAMA Sales KodaDot - NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner August 7, 2023 08:50
@roiLeo roiLeo requested review from vikiival and daiagi and removed request for a team August 7, 2023 08:50
@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f0cd2c9
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64d23300204b6700079d1537
😎 Deploy Preview https://deploy-preview-6594--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 7, 2023

AI-Generated Summary: This pull request includes refactorings and minor style adjustments to the ProfileLink and ScrollTopButton components. In ProfileLink.vue, the previous mixins and component imports have been replaced with the Composition API setup function, yielding a leaner, more direct implementation.

The ScrollTopButton.vue also transitions to the Composition API with usage of ref and lifecycle hooks. This change provides a more declarative approach to the component's functionality.

There are slight changes in the styles as well with change of right in _scroll-to-top-button.scss. These alterations contribute to code cleanup and potentially better performance.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 7, 2023
@reviewpad reviewpad bot added medium Pull request is medium and removed small Pull request is small labels Aug 7, 2023
@roiLeo roiLeo changed the title 🔧 ProfileLink & ScrollTopButton 🔧 ProfileLink, ScrollTopButton & HotTable Aug 7, 2023
@vikiival
Copy link
Member

vikiival commented Aug 7, 2023

maybe different logo without background?

Screenshot 2023-08-07 at 13 14 37

Kusama Branding Assets

@vikiival
Copy link
Member

vikiival commented Aug 7, 2023

Opened issue for the data view

Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, couple of q please

  1. how to navigate to this page (hot)? (i.e do we even need it anymore?)
  2. could you move it under prefix?

image

@roiLeo
Copy link
Contributor Author

roiLeo commented Aug 7, 2023

looks good, couple of q please

1. how to navigate to this page (hot)? (i.e do we even need it anymore?)

2. could you move it under prefix?

If I remember we hide it a while ago, it will be reintroduce once we'll fixed all stuff in StatsDropdown (series, spotlight, sales, hot etc..)

@prury
Copy link
Member

prury commented Aug 7, 2023

regarding showing identity on the profile page, even if a user has it in its identity, we are not currently showing social media handles, right?

overlay now:
image
if its better, then it works for me

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 7, 2023
@roiLeo
Copy link
Contributor Author

roiLeo commented Aug 7, 2023

regarding showing identity on the profile page, even if a user has it in its identity, we are not currently showing social media handles, right?

I think we are showing them in profile detail page (/:prefix/u/:id)

@reviewpad reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Aug 7, 2023
@roiLeo roiLeo changed the title 🔧 ProfileLink, ScrollTopButton & HotTable 🔧 ProfileLink, ScrollTopButton, HotTable & SalesTable Aug 8, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 8, 2023

Code Climate has analyzed commit f0cd2c9 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

@roiLeo roiLeo mentioned this pull request Aug 8, 2023
@yangwao yangwao merged commit f0cd2c9 into kodadot:main Aug 8, 2023
16 of 20 checks passed
This was referenced Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot page shows different results, but they are all RMRK1 back to top does weird overlay apparently
5 participants