Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 vue3 composition #6649

Merged
merged 5 commits into from
Aug 10, 2023
Merged

🔧 vue3 composition #6649

merged 5 commits into from
Aug 10, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Aug 10, 2023

@roiLeo roiLeo requested a review from a team as a code owner August 10, 2023 12:22
@roiLeo roiLeo requested review from preschian and vikiival and removed request for a team August 10, 2023 12:22
@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d766f7f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64d4d681e9197000087be7ba
😎 Deploy Preview https://deploy-preview-6649--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codeclimate
Copy link

codeclimate bot commented Aug 10, 2023

Code Climate has analyzed commit d766f7f and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 10, 2023

AI-Generated Summary: This pull request includes changes in five vue files, mainly updating them to use Vue3 Composition API.

The first is Interface.vue, where the component is refactored from nuxt-property-decorator to Vue3 Composable API logic, with parts of the template also updated.

Similarly, UserGainHistory.vue is refactored to use Vue3 Composition API, with updates to the components and props.

PriceRange.vue is also modified to use Vue3 Composition API and useRoute, useChain functions with updates to the props and computed properties.

The update also includes refactoring of StatsColumn.vue and Layout.vue. Components, props, computed properties are updated to useVue3 Composition API using defineProps(), ref(), computed(), defineEmits().

Overall, the patch focuses on updating Vue2 syntax and structure to Vue3, enhancing the readability and maintainability of the codebase.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Aug 10, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 10, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.7% 2.7% Duplication

@yangwao
Copy link
Member

yangwao commented Aug 10, 2023

well cypress gone, I would merge it let's go

image

@yangwao yangwao merged commit 4e83b98 into kodadot:main Aug 10, 2023
14 checks passed
@roiLeo roiLeo deleted the chore/vue3/compo branch August 10, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants