Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove sentry related packages #6672

Merged
merged 1 commit into from
Aug 11, 2023
Merged

chore: remove sentry related packages #6672

merged 1 commit into from
Aug 11, 2023

Conversation

preschian
Copy link
Member

@preschian preschian requested a review from a team as a code owner August 11, 2023 08:05
@preschian preschian requested review from daiagi and Jarsen136 and removed request for a team August 11, 2023 08:05
@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4e9102b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64d5ebd13e1739000888a894
😎 Deploy Preview https://deploy-preview-6672--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codeclimate
Copy link

codeclimate bot commented Aug 11, 2023

Code Climate has analyzed commit 4e9102b and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 11, 2023

AI-Generated Summary: This pull request makes significant changes to the project, primarily concerning the removal of Sentry integration.

The sentry.ts file under the plugins directory, which was responsible for creating the Sentry Replay object, has been deleted entirely. In the package.json file, three dependencies related to Sentry have been removed: "@nuxtjs/sentry," "@sentry/browser," and "@sentry/webpack-plugin". As a result, it is suggested that the project's error logging and reporting features be ensured for proper functioning after these changes, or suitable alternatives may need to be installed.

In the nuxt.config.js file, several modifications were done in relation to removing Sentry, such as the import removal of middleware @sentry/webpack-plugin, removal of @nuxtjs/sentry from the middleware list, and complete excision of the Sentry integration configuration. These modifications seem to indicate a conscious decision to cease using Sentry in the project.

The tsconfig.json file was also updated, with one notable change being the removal of @nuxtjs/sentry from the project dependencies. Lastly, in the utils/notification.ts file, two functionalities relating to Sentry have been removed - the import and usage of captureMessage - which means that errors will no longer be recorded.

@reviewpad reviewpad bot added the large Pull request is large label Aug 11, 2023
@preschian preschian mentioned this pull request Aug 11, 2023
1 task
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 11, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@preschian preschian requested a review from roiLeo August 11, 2023 08:08
@yangwao yangwao merged commit 6eda9d3 into main Aug 11, 2023
14 checks passed
@yangwao yangwao deleted the chore/remove-sentry branch August 11, 2023 08:58
This was referenced Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants