Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: menu buttons resseting scroll position on mobile #6673

Merged
merged 3 commits into from
Aug 12, 2023

Conversation

stephenjason89
Copy link
Contributor

@stephenjason89 stephenjason89 commented Aug 11, 2023

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 769abca

Refactored the code for opening the shopping cart modal from the navbar. Moved the logic and configuration from ShoppingCartModalConfig.ts and ShoppingCartButton.vue to Navbar.vue to improve code organization and performance.

🤖 Generated by Copilot at 769abca

ShoppingCartButton
Simpler, no more emit -
Autumn leaves falling

@stephenjason89 stephenjason89 requested a review from a team as a code owner August 11, 2023 08:20
@stephenjason89 stephenjason89 requested review from preschian and roiLeo and removed request for a team August 11, 2023 08:20
@kodabot
Copy link
Collaborator

kodabot commented Aug 11, 2023

SUCCESS @stephenjason89 PR for issue #6667 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 704b766
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64d605c757541c00086f5e1d
😎 Deploy Preview https://deploy-preview-6673--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 11, 2023

AI-Generated Summary: This pull request contains changes to the Navbar.vue component to fix an issue where on mobile, the menu buttons were resetting the scroll position. The fix involved removing two lines of code. The first line removed a Vue directive v-if="account" from the NotificationBoxButton component. The second line removed was the command document.body.classList.toggle('is-clipped') which was toggling a CSS class on the body. Removing this line prevents the toggling of this class which in turn prevents the scroll position from being reset.

components/Navbar.vue Outdated Show resolved Hide resolved
components/Navbar.vue Show resolved Hide resolved
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roiLeo roiLeo added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Aug 11, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 11, 2023

Code Climate has analyzed commit 704b766 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@roiLeo roiLeo requested a review from prury August 11, 2023 10:35
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@roiLeo
Copy link
Contributor

roiLeo commented Aug 11, 2023

waiting for @prury review

@prury
Copy link
Member

prury commented Aug 11, 2023

Notifications ✔️
Shopping Cart ✔️
Profile ✔️

For chain switching lets wait for #6613

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Aug 11, 2023
@yangwao yangwao added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 12, 2023
@yangwao
Copy link
Member

yangwao commented Aug 12, 2023

pay 60 usd

@yangwao
Copy link
Member

yangwao commented Aug 12, 2023

😍 Perfect, I’ve sent the payout
💵 $60 @ 5.03 USD/DOT ~ 11.928 $DOT
🧗 16UcV9V6nVvPYdHz98ymUKmNLkzjCEU5sbKJMi7hxYyTHjzR
🔗 0x7a70f99824f21f6d60bdb3c7a4e993ed935c0bd6b41f9b7c844f556e69fabc25

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 12, 2023
@yangwao yangwao merged commit 9991dbe into kodadot:main Aug 12, 2023
14 checks passed
@yangwao yangwao mentioned this pull request Aug 16, 2023
@yangwao yangwao mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu buttons resseting scroll position on mobile
5 participants