Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Buy now spinning wheel #6674

Merged
merged 10 commits into from
Aug 12, 2023
Merged

feat: Buy now spinning wheel #6674

merged 10 commits into from
Aug 12, 2023

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Aug 11, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Added loading state when trying to buy item and wallet is not connected , should show loading state with wallet label

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI;
CleanShot.2023-08-11.at.14.26.57.mp4

Copilot Summary

🤖 Generated by Copilot at 626607f

This pull request enhances the user experience and functionality of buying NFTs from the gallery. It adds a new prop showActionOnHover to NeoNftCard and ItemsGridImage components to control the visibility of the action buttons. It also fixes a bug with the wallet connection modal and adds a new feature to remember the selected item and resume the purchase after connecting the wallet. It updates the useDoAfterlogin composable and the shoppingCart store to support the new feature and the onCancel callback. It also adds a new translation key and some style changes.

🤖 Generated by Copilot at 626607f

NeoNftCard changes
Show or hide action buttons
Autumn leaves falling

@hassnian hassnian requested a review from a team as a code owner August 11, 2023 09:20
@hassnian hassnian requested review from vikiival and daiagi and removed request for a team August 11, 2023 09:20
@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit cc0d933
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64d7332680e3600007a3c789
😎 Deploy Preview https://deploy-preview-6674--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Aug 11, 2023

SUCCESS @hassnian PR for issue #6626 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 11, 2023

AI-Generated Summary: This pull request includes a series of patches involving multiple changes and fixes. It makes several updates to the wallet functionality, item-purchasing process, and interface styles across different components:

  1. Updates to the wallet-connect functionality: A cancel option is added to the OpenWalletModalConfig, and the 'modal.value' is nullified only when the 'onCancel' function is called.

  2. Improvements in the buying process in ItemsGridImage.vue: The buy button becomes a loading spinner when a user is in the process of connecting their wallet. A 'buyLabel' is also added to display a 'wallet' message while the wallet is being connected.

  3. Fixes a minor translation issue in the buyLabel area.

  4. Check if the user is logged in before showing the wallet connection process.

  5. Refactors the hover-action to just action for simplicity and clarity.

  6. Adds style updates for the loading button during the wallet connection process.

Overall, this pull request enhances the user experience and functionality during the wallet connection and item-purchasing processes.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Aug 11, 2023
@hassnian hassnian marked this pull request as draft August 11, 2023 09:29
@hassnian hassnian marked this pull request as ready for review August 11, 2023 09:52
@hassnian hassnian changed the title (feat) Buy now spinning wheel feat: Buy now spinning wheel Aug 11, 2023
components/items/ItemsGrid/ItemsGridImage.vue Outdated Show resolved Hide resolved
stores/shoppingCart.ts Outdated Show resolved Hide resolved
components/items/ItemsGrid/ItemsGridImage.vue Outdated Show resolved Hide resolved
components/items/ItemsGrid/ItemsGridImage.vue Outdated Show resolved Hide resolved
@exezbcz
Copy link
Member

exezbcz commented Aug 11, 2023

works for me, nice job!

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 11, 2023
@daiagi daiagi added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Aug 12, 2023
@hassnian hassnian requested a review from daiagi August 12, 2023 07:04
@codeclimate
Copy link

codeclimate bot commented Aug 12, 2023

Code Climate has analyzed commit cc0d933 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

rounded?: boolean
tag?: string
}>()
withDefaults(
Copy link
Contributor

@daiagi daiagi Aug 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need withDefaults
Declaring optional prop loadingWithLabel?: boolean

Also works

other than that lgtm

@daiagi daiagi added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Aug 12, 2023
@yangwao
Copy link
Member

yangwao commented Aug 12, 2023

pay 50 usd

@yangwao yangwao merged commit af9017d into kodadot:main Aug 12, 2023
13 of 14 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 12, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 5.03 USD/DOT ~ 9.94 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0xfe8bfea10468e91d705c2672c828eafad8413fd0fd080fb3d9de9a49d0deaf49

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 12, 2023
This was referenced Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buy now spinning wheel
6 participants