Changed color of content text (not title & subtitle) for blogs and ad…

[seanzboland]

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

• Bugfix
• Feature
• Refactoring

Context

• Closes Blog article styling  #6680
• Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality

Optional

• I've tested it at </ksm/collection>
• I've tested PR on mobile
• I've written unit tests 🧪
• I've found edge cases

Did your issue had any of the "$" label on it?

• Fill up your DOT address: Payout

Community participation

• Are you at KodaDot Discord?

Screenshot 📸

• My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 79f61ff

This pull request improves the readability and appearance of the blog posts by tweaking the color of some elements and the spacing of the headings in the .markdown-body class. It modifies the k-accentlight2-dark variable in _theme.scss and adds some CSS rules to BlogPost.vue.

🤖 Generated by Copilot at 79f61ff

markdown-body styled
More space for headings, code
A breath of spring air

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	19be55c
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/64dddbac7da33600087ab12f
😎 Deploy Preview	https://deploy-preview-6683--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[reviewpad]

AI-Generated Summary: This pull request introduces visual adjustments to the blog post layout in the application. Specifically, it adds more spacing between headers (h1, h2, h3, h4) from the second child onwards in blog posts, introducing a larger gap of 3rem for better readability and structure. Also, it changes the color of the content text (excluding headers) in the theme's SCSS file. It modifies the color values assigned to 'k-accentlight2-dark': the color goes from '#363234' to '#191718' for the first theme and from '#ffffff' to '#b9b9b9' for the second. These changes should improve the aesthetic look and feel of blog posts in the application.

[exezbcz]

12px here

• I cant see colors changed

[seanzboland]

12px here

• I cant see colors changed

@exezbcz
The text color is changed from #ffffff into #b9b9b9

[seanzboland]

@exezbcz
Do you mean 12px for the margin?
It was asked to add more margin on top of each paragraph (between paragraph title and its previous paragraph)

[exezbcz]

@seanzboland

• the color combination should look like this, see figma please: https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?type=design&node-id=1296%3A18906&mode=design&t=ui19mdbDi2UZVUUS-1
• I think you changed the color token, k-accentlight2dark should stay the same, we are changing the color of the content, not the color token, correct me if I am wrong

[seanzboland]

@exezbcz
Please confirm if I am thinking correctly.

• I will keep color for title of each paragraph, and try to change only the color of content
• Can I add a new token for dark/light mode for this blog text color?
  Actually, k-accentlight2dark is only used for blog text color, and that's why I wanted to change it.

[yangwao]

@seanzboland please use Pull Template otherwise I'm closing your PR.

[exezbcz]

@seanzboland

• I will keep color for title of each paragraph, and try to change only the color of content

yes, color of heading for darkmode

• Can I add a new token for dark/light mode for this blog text color?
  Actually, k-accentlight2dark is only used for blog text color, and that's why I wanted to change it.

not sure, you would have to ask devs

[yangwao]

how they are here 4 participants 👀

[exezbcz]

@seanzboland any updates sir?

[seanzboland]

I saw my assignation for the ticket is revoked.

…

On Wed, Aug 16, 2023 at 2:26 PM Exez ***@***.***> wrote: @seanzboland <https://github.com/seanzboland> any updates sir? — Reply to this email directly, view it on GitHub <#6683 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARWCLEYKMACM42LBHD7TS2LXVUGEPANCNFSM6AAAAAA3NIS2HI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[exezbcz]

@seanzboland If you want, you can still work on this issue. So that you know, there's a risk someone else could be assigned and deliver earlier.

[roiLeo]

✅ code lgtm

[seanzboland]

Merging can be performed automatically with 2 approving reviews.

@roiLeo
I have 1 approval now, and would like to hear the following steps.

[seanzboland]

@exezbcz
I would like to continue work on ticket, and updated regarding your comments.
Please check it.

[seanzboland]

[vikiival]

Code oki

@exezbcz pls confirm if its visually oki

[exezbcz]

• please change the color of subheading as well in dark mode to the paragraph text

this should be 40, not 48px

• this should be 12px
  

light mode

• same colors as here (k-darkmode), use it for subheading please as well
• here:
  
  h1 stays true black, that is correct

Otherwise oki!

[seanzboland]

@exezbcz
I changed colour of subtitle and fixed the margin

[exezbcz]

smol detail
in light mode the h2 has different color from the p text

should be this one: #191718

[seanzboland]

@exezbcz
I fixed it.

[codeclimate]

Code Climate has analyzed commit 19be55c and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[yangwao]

pay 30 usd

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.75 USD/DOT ~ 6.316 $DOT
🧗 12AiUwY6xy6jmKQELdxWPSKacd5tqXBYjcq3p1gx63Mhmcgz
🔗 0x53d39181a4fccb4ec0882fb3f5ae2f4a41a1fd3f1dfeb52072c6de5e19d7e7cd

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues