Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chain redirects): Follow up: Changing network in navbar always redirects to Landing page #6688

Merged
merged 55 commits into from
Aug 17, 2023

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Aug 12, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

Profile Page
CleanShot 2023-08-13 at 14 50 47

Transfer Page
CleanShot 2023-08-13 at 14 56 14

Identity Page
CleanShot 2023-08-13 at 18 48 17

Drops Page
CleanShot 2023-08-15 at 06 45 21

Teleport Page
CleanShot 2023-08-15 at 06 47 19

Incoming Offers
CleanShot 2023-08-15 at 06 48 02

Copilot Summary

🤖 Generated by Copilot at 11de2ef

Added chain-specific features for identity and transfer pages. useChainRedirect composable and permision.config.ts file handle the logic and configuration of showing or hiding these features and redirecting users to the appropriate chain.

🤖 Generated by Copilot at 11de2ef

To support different chains with ease
They added some configs and keys
With useChainRedirect
They can now detect
The page type and availability

@kodabot
Copy link
Collaborator

kodabot commented Aug 12, 2023

SUCCESS @hassnian PR for issue #6678 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 12, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 9973d55
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64dde6db1be56d00089b22a6
😎 Deploy Preview https://deploy-preview-6688--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 12, 2023

AI-Generated Summary: This pull request includes two patches.

The first patch fixes an issue in the useChainRedirect.ts file where the function was not checking if a page is available for a specific chain before proceeding with the redirection logic. The patch adds this condition and also introduces PREFIX_TRANSFER to the PageType enum.

The second patch enhances the useChainRedirect.ts file by adding IDENTITY to the PageType enum and adding conditions for PREFIX_TRANSFER and IDENTITY in the pageAvailabilityPerChain object. It also includes an update in permision.config.ts, where it introduces visibility configurations for 'identity' and 'transfer'. These configurations indicate if the 'identity' and 'transfer' features are available for the supported chains.

@reviewpad reviewpad bot added the small Pull request is small label Aug 12, 2023
@reviewpad reviewpad bot added medium Pull request is medium and removed small Pull request is small labels Aug 13, 2023
@reviewpad reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Aug 13, 2023
@hassnian
Copy link
Contributor Author

@prury had to change some code, feel free to test if everything works :D

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use navigateTo('/') instead

pages/sales.vue Outdated Show resolved Hide resolved
pages/_prefix/explore/collectibles.vue Outdated Show resolved Hide resolved
components/drops/Drops.vue Outdated Show resolved Hide resolved
components/drops/Drops.vue Outdated Show resolved Hide resolved
pages/_prefix/explore/items.vue Outdated Show resolved Hide resolved
pages/sales.vue Outdated Show resolved Hide resolved
pages/series-insight.vue Outdated Show resolved Hide resolved
@hassnian hassnian requested a review from roiLeo August 17, 2023 06:49
components/navbar/NavbarChainOptions.vue Outdated Show resolved Hide resolved
@yangwao
Copy link
Member

yangwao commented Aug 17, 2023

Follow up about this one, then?

https://codeclimate.com/github/kodadot/nft-gallery/pull/6688

image

components/identity/utils/useIdentity.ts Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Aug 17, 2023

Code Climate has analyzed commit 9973d55 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yangwao
Copy link
Member

yangwao commented Aug 17, 2023

pay 50 usd
builds
image

@yangwao yangwao merged commit 280b4f1 into kodadot:main Aug 17, 2023
13 of 14 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 17, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.76 USD/DOT ~ 10.504 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0x3067b20fe709e088a09d27a07b251c3b049c8f737f55fd58616319fa54298406

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 17, 2023
@hassnian hassnian deleted the issue-6678 branch August 17, 2023 09:27
@hassnian
Copy link
Contributor Author

@yangwao I think something went wrong with the payout 👀
CleanShot 2023-08-17 at 14 45 48@2x

@vikiival vikiival removed the paid pull-request has been paid label Aug 17, 2023
@vikiival
Copy link
Member

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Aug 17, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.77 USD/DOT ~ 10.482 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0x61e6e80c3cd9270ca425cf9ad6ecf889fe9c3c2b9bcb37d0223734070269599a

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 17, 2023
@yangwao
Copy link
Member

yangwao commented Aug 17, 2023

@yangwao I think something went wrong with the payout 👀

yeah we are caching balances too much and I was topping up balance on bot, yet wasn't that much on address, so it failed and than failed in cascade here :)

would be nice to check balances on sidebar and check for that like at least once per 30 seconds?

@prury prury mentioned this pull request Aug 17, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow up: Changing network in navbar always redirects to Landing page
9 participants