-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: exit on failed to parse #6690
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request includes various changes over eight patches.
In summary, this PR primarily focuses on improving error handling, updating scripts, adding & configuring Node.js CI, and code cleanup. |
Reviewpad Report
|
Code Climate has analyzed commit d9d61af and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Context
Previously, the build step didn't properly return
process.exit(1)
if it failed. So, the CI will continue the process and mark it as a success. That's why we see 404 pages after deployment. The build is supposed to be incomplete and fails. Now it will stop the deployment if the build step fails.