Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: exit on failed to parse #6690

Merged
merged 9 commits into from
Aug 13, 2023
Merged

Conversation

preschian
Copy link
Member

@preschian preschian commented Aug 13, 2023

Context

Previously, the build step didn't properly return process.exit(1) if it failed. So, the CI will continue the process and mark it as a success. That's why we see 404 pages after deployment. The build is supposed to be incomplete and fails. Now it will stop the deployment if the build step fails.

before after
Screenshot 2023-08-13 at 11 57 10 AM Screenshot 2023-08-13 at 11 56 04 AM
Screenshot 2023-08-13 at 11 49 00 AM Screenshot 2023-08-13 at 11 47 45 AM

@netlify
Copy link

netlify bot commented Aug 13, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d9d61af
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64d886bab16784000884bc98
😎 Deploy Preview https://deploy-preview-6690--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 13, 2023

AI-Generated Summary: This pull request includes various changes over eight patches.

  1. The first patch makes changes to nuxt.config.js, package.json, and adds a new script generate.mjs which checks if there is a 'failed to parse' message in the stdout or stderr and exits the process if such a message is found.
  2. The second patch renames the generate script to generate:script in package.json and updates the usage of pnpm to now use pnpm generate:script in generate.mjs.
  3. The third patch makes updates to nuxt.config.js for handling source maps.
  4. The fourth patch creates a new file .github/workflows/node.yml to include Node.js CI.
  5. The fifth patch modifies generate.mjs to exit the process whenever a stderr message is received.
  6. The sixth patch disables source-map in nuxt.config.js and updates a title in SearchLanding.vue.
  7. The seventh patch cleans up some comments, code, and a string change made in previous patches. The 'nuxt-webpack-optimisations' is once again included in the buildModules.
  8. The eighth and the last patch removes the previously created .github/workflows/node.yml file.

In summary, this PR primarily focuses on improving error handling, updating scripts, adding & configuring Node.js CI, and code cleanup.

@preschian preschian changed the title Ci-exit-on-fails-generate ci: exit on failed to parse Aug 13, 2023
@reviewpad reviewpad bot added the small Pull request is small label Aug 13, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 13, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@preschian preschian marked this pull request as ready for review August 13, 2023 05:26
@preschian preschian requested a review from a team as a code owner August 13, 2023 05:26
@preschian preschian requested review from vikiival and daiagi and removed request for a team August 13, 2023 05:26
@codeclimate
Copy link

codeclimate bot commented Aug 13, 2023

Code Climate has analyzed commit d9d61af and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yangwao yangwao merged commit 6b4ce05 into kodadot:main Aug 13, 2023
14 checks passed
@preschian preschian deleted the ci-exit-on-fails-generate branch August 13, 2023 20:46
@preschian preschian mentioned this pull request Aug 14, 2023
4 tasks
This was referenced Aug 16, 2023
@preschian preschian mentioned this pull request Aug 19, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants