Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 PriceChart vue3 #6720

Merged
merged 1 commit into from
Aug 16, 2023
Merged

🔧 PriceChart vue3 #6720

merged 1 commit into from
Aug 16, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Aug 15, 2023

@roiLeo roiLeo requested a review from a team as a code owner August 15, 2023 13:34
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team August 15, 2023 13:34
@netlify
Copy link

netlify bot commented Aug 15, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e7b8a5a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64db7ee3e0fc99000727b97e
😎 Deploy Preview https://deploy-preview-6720--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 15, 2023

AI-Generated Summary: This pull request refactors the 'PriceChart.vue' component of the codebase, switching it from Vue 2 to Vue 3 Composition API structure. Vast changes include removal of the importing of ChainMixin, replacing the previously class-based structure of the component with the use of reactive 'ref' and 'watch' methods. Events are now emitted directly in the template. Furthermore, the 'mounted' lifecycle hook has been replaced with the 'onMounted' method, and a 'watch' declaration has been introduced to observe changes in 'priceData' and re-run 'priceChart'. Overall, the patch enhances code readability and leverages Vue 3's composition API for better state management.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Aug 15, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 15, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Aug 15, 2023

Code Climate has analyzed commit e7b8a5a and detected 0 issues on this pull request.

View more on Code Climate.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 15, 2023
@yangwao yangwao self-requested a review August 16, 2023 10:32
@yangwao yangwao merged commit 55534dd into kodadot:main Aug 16, 2023
14 checks passed
This was referenced Aug 16, 2023
Merged
Merged
@roiLeo roiLeo deleted the chore/vue3/PriceChart branch August 16, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@yangwao yangwao yangwao approved these changes

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
medium Pull request is medium S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roiLeo @preschian @yangwao @prury