Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 PulseChart vue3 #6724

Merged
merged 2 commits into from
Aug 16, 2023
Merged

🔧 PulseChart vue3 #6724

merged 2 commits into from
Aug 16, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Aug 15, 2023

@roiLeo roiLeo requested a review from a team as a code owner August 15, 2023 14:15
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team August 15, 2023 14:15
@netlify
Copy link

netlify bot commented Aug 15, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d4015b1
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64dc79876dda35000801f89e
😎 Deploy Preview https://deploy-preview-6724--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 15, 2023

AI-Generated Summary: This pull request updates the PulseChart.vue component to use options from Vue 3. The changes include the switch of the component declaration from Vue 2's options-based API to Vue 3's Composition API. The Lifecycle hooks and data are now defined as JavaScript functions and variables instead of being under properties of the Component decorator. The property now uses Vue 3's defineProps function. Significant changes are found in the setup, mounted methods and rendering of the chart. The chart is now stored in a ref instead of a protected variable. Overall, these changes leverage Vue 3's enhanced Composition API for better readability and maintainability.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Aug 15, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 15, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo enabled auto-merge August 16, 2023 07:23
@codeclimate
Copy link

codeclimate bot commented Aug 16, 2023

Code Climate has analyzed commit d4015b1 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yangwao yangwao self-requested a review August 16, 2023 10:30
@roiLeo roiLeo merged commit b350809 into kodadot:main Aug 16, 2023
14 checks passed
This was referenced Aug 16, 2023
Merged
Merged
@roiLeo roiLeo deleted the chore/vue3/PulseChart branch August 16, 2023 10:39
This was referenced Aug 18, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@yangwao yangwao yangwao approved these changes

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
medium Pull request is medium waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roiLeo @preschian @yangwao