Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Collection pfp object fit #6728

Merged
merged 1 commit into from
Aug 16, 2023
Merged

fix: Collection pfp object fit #6728

merged 1 commit into from
Aug 16, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Aug 15, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at e1eeea8

This pull request updates the image styling for the CollectionBanner and UnlockableCollectionBanner components by adding the object-fit-cover class to the img elements. This class is defined in the global.scss file, which is also modified to remove an unused class. The goal is to make the banner images fit the containers better and improve the visual appearance of the collections.

🤖 Generated by Copilot at e1eeea8

To make the banner images fit
The object-fit-cover class was a hit
But it had to be moved
To another component improved
And the global styles got a bit of a split

@Jarsen136 Jarsen136 requested a review from a team as a code owner August 15, 2023 15:27
@Jarsen136 Jarsen136 requested review from vikiival and daiagi and removed request for a team August 15, 2023 15:27
@kodabot
Copy link
Collaborator

kodabot commented Aug 15, 2023

SUCCESS @Jarsen136 PR for issue #6718 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e1eeea8
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64db9961ab5f4d0008676484
😎 Deploy Preview https://deploy-preview-6728--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codeclimate
Copy link

codeclimate bot commented Aug 15, 2023

Code Climate has analyzed commit e1eeea8 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 15, 2023

AI-Generated Summary: This pull request introduces a fix for the image fitting issue in collections. The "object-fit-cover" class has been added to images in both the CollectionHeader and UnlockableCollectionBanner components, ensuring that these images are displayed properly. Additionally, a new CSS definition for the "object-fit-cover" class was introduced in the global.scss file, applying the CSS property "object-fit: cover". Overall, these changes enhance the visual display of collection images, improving the user interface of the application.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

@Jarsen136
Copy link
Contributor Author

Two kinds of object-fit could be chosen. Which one do you prefer to? @exezbcz

object-fit: contain
image

object-fit: cover
image

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exezbcz please ping once approved

@exezbcz
Copy link
Member

exezbcz commented Aug 15, 2023

Two kinds of object-fit could be chosen. Which one do you prefer to? @exezbcz

object-fit: contain
image

object-fit: cover
image

Cover please

@vikiival vikiival merged commit 12693a8 into kodadot:main Aug 16, 2023
15 checks passed
This was referenced Aug 16, 2023
@yangwao
Copy link
Member

yangwao commented Aug 17, 2023

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Aug 17, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 4.77 USD/DOT ~ 4.193 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x5336eeaeba15b2d958ec8f1d0e9dddf1f89e12385358beb3f770d5a5c7f1f988

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 17, 2023
This was referenced Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection pfp object fit
6 participants