-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Collection pfp object fit #6728
Conversation
SUCCESS @Jarsen136 PR for issue #6718 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Code Climate has analyzed commit e1eeea8 and detected 0 issues on this pull request. View more on Code Climate. |
AI-Generated Summary: This pull request introduces a fix for the image fitting issue in collections. The "object-fit-cover" class has been added to images in both the CollectionHeader and UnlockableCollectionBanner components, ensuring that these images are displayed properly. Additionally, a new CSS definition for the "object-fit-cover" class was introduced in the global.scss file, applying the CSS property "object-fit: cover". Overall, these changes enhance the visual display of collection images, improving the user interface of the application. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Two kinds of object-fit could be chosen. Which one do you prefer to? @exezbcz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@exezbcz please ping once approved
Cover please |
pay 20 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs Design check
Context
Did your issue had any of the "$" label on it?
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at e1eeea8
This pull request updates the image styling for the
CollectionBanner
andUnlockableCollectionBanner
components by adding theobject-fit-cover
class to theimg
elements. This class is defined in theglobal.scss
file, which is also modified to remove an unused class. The goal is to make the banner images fit the containers better and improve the visual appearance of the collections.🤖 Generated by Copilot at e1eeea8