🔧 LineChart vue3 #6736

roiLeo · 2023-08-16T11:11:56Z

ref Reduce using nuxt-property-decorator and use composition API #4750

netlify · 2023-08-16T11:12:01Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`385f5ff`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/64dcaefe53029e00081d9e29
😎 Deploy Preview	https://deploy-preview-6736--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codeclimate · 2023-08-16T11:12:23Z

Code Climate has analyzed commit 385f5ff and detected 0 issues on this pull request.

View more on Code Climate.

reviewpad · 2023-08-16T11:12:29Z

AI-Generated Summary: This pull request involves changes in the LineChart.vue file where it replaces the ChartMixin with newer Vue.js 3 Composition API syntax to improve maintainability and provides a more readable and testable code. The key alterations can be listed as follows:

The specific import of a 'ChartMixin' ts file and its associated decorators has been removed.
Life-cycle methods onMounted and onBeforeUnmount have been introduced to appropriately manage event-listeners on the window object for 'resize' event.
A renderChart function has been defined as a replacement for ChartMixin.
This function creates a new chart.js instance or updates the existing one based on the component's current state.
The window resize handling has been extracted to its own onWindowResize function.

In addition, the deletion of the ChartMixin.ts file indicates a move away from Vue.js mixins towards the use of composition API, due to added advantages like better TypeScript integration and code reusability.