Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗑️ remove on-finality RPC nodes #6751

Merged
merged 1 commit into from
Aug 17, 2023
Merged

🗑️ remove on-finality RPC nodes #6751

merged 1 commit into from
Aug 17, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Aug 17, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • Chore

Context

Screenshot 2023-08-17 at 14 08 30

Copilot Summary

🤖 Generated by Copilot at bec72bb

Removed OnFinality endpoints from endpoints.ts to improve NFT gallery reliability.

🤖 Generated by Copilot at bec72bb

OnFinality is gone, we don't need it anymore
We purge the errors, we enhance the core
Our gallery of NFTs, a shining display of art
We defy the system, we tear it apart

@vikiival vikiival requested a review from a team as a code owner August 17, 2023 11:08
@vikiival vikiival requested review from preschian and Jarsen136 and removed request for a team August 17, 2023 11:08
@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit bec72bb
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64ddffafb7232300070fd46d
😎 Deploy Preview https://deploy-preview-6751--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 17, 2023

AI-Generated Summary: This pull request involves the removal of on-finality RPC nodes from the application. The changes are made to the 'endpoints.ts' file where multiple URLs related to on-finality RPC nodes have been deleted from KUSAMA_ENDPOINTS, POLKADOT_ENDPOINTS and ALTERNATIVE_ENDPOINT_MAP objects. This leads to a total of 4 lines of code being deleted. It suggests that connections to the mentioned nodes are not required anymore or been deprecated, hence removed from the list of endpoints.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 17, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 17, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Aug 17, 2023

Code Climate has analyzed commit bec72bb and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yangwao
Copy link
Member

yangwao commented Aug 17, 2023

lel extract0rs :)
we will probably run our own nodes by time anyways, so I think this is their missed opportunity 👀

@yangwao yangwao merged commit a7d0956 into main Aug 17, 2023
15 checks passed
@yangwao yangwao deleted the no-finality branch August 17, 2023 11:15
@yangwao
Copy link
Member

yangwao commented Aug 17, 2023

This was referenced Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants