Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 GalleryCard vue3 #6752

Merged
merged 1 commit into from
Aug 17, 2023
Merged

🔧 GalleryCard vue3 #6752

merged 1 commit into from
Aug 17, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Aug 17, 2023

@roiLeo roiLeo requested a review from a team as a code owner August 17, 2023 12:00
@roiLeo roiLeo requested review from vikiival and daiagi and removed request for a team August 17, 2023 12:00
@netlify
Copy link

netlify bot commented Aug 17, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 8c0b349
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64de0bc9005b06000848a65f
😎 Deploy Preview https://deploy-preview-6752--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codeclimate
Copy link

codeclimate bot commented Aug 17, 2023

Code Climate has analyzed commit 8c0b349 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 17, 2023

AI-Generated Summary: This pull request introduces a significant refactor of the GalleryCard.vue component to comply with Vue 3's composition-API style.

The changes primarily encompass an overhaul of the script section within the mentioned component. The edit incorporates a preferable, more modern approach for incorporating components, properties, data, and computed properties via imports, setup, refs, computed, and defineProps functions. This fundamentally eliminates the need to use Vue mixins. Furthermore, the pull request introduces the 'useLazyAsyncData' for asynchronously fetching and rendering NFT metadata.

The proposed alteration paves the way for a more manageable, readable, and efficient script structure in alignment with modern Vue conventions.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Aug 17, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 17, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 17, 2023
@yangwao yangwao merged commit b57b6d5 into kodadot:main Aug 17, 2023
14 checks passed
@roiLeo roiLeo deleted the chore/vue3/GalleryCard branch August 17, 2023 13:41
This was referenced Aug 18, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival Awaiting requested review from vikiival vikiival is a code owner automatically assigned from kodadot/code-review-guild

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
medium Pull request is medium S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roiLeo @yangwao @prury