Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Loader vue3 #6753

Merged
merged 3 commits into from
Aug 17, 2023
Merged

🔧 Loader vue3 #6753

merged 3 commits into from
Aug 17, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Aug 17, 2023

@roiLeo roiLeo requested a review from a team as a code owner August 17, 2023 12:11
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team August 17, 2023 12:11
@netlify
Copy link

netlify bot commented Aug 17, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit b9d6417
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64de13b283e2940008571caa
😎 Deploy Preview https://deploy-preview-6753--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 17, 2023

AI-Generated Summary: This pull request updates the 'Loader.vue' component from the Vue 2 style to Vue 3 Composition API. It modifies and reorganizes the component properties and lifecycle hooks to align with Vue 3 syntax and uses ref() and computed() for reactive properties. It also replaces the event emitting mechanism to conform to Vue 3 conventions. The new code is cleaner due to lesser boilerplate and better organization. Names of few variables are also changed to make their purpose clearer.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 17, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 17, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Jarsen136
Jarsen136 reviewed Aug 17, 2023
View reviewed changes
components/shared/Loader.vue Outdated Show resolved Hide resolved
components/shared/Loader.vue Outdated Show resolved Hide resolved
roiLeo and others added 2 commits August 17, 2023 14:33
@roiLeo @Jarsen136
Update components/shared/Loader.vue
e6bbd16 
Co-authored-by: Jarsen <31397967+Jarsen136@users.noreply.github.com>
@roiLeo @Jarsen136
Update components/shared/Loader.vue
b9d6417 
Co-authored-by: Jarsen <31397967+Jarsen136@users.noreply.github.com>
@codeclimate
Copy link

codeclimate bot commented Aug 17, 2023

Code Climate has analyzed commit b9d6417 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 17, 2023
@vikiival
Copy link
Member

You deserve a meme sir

7w1mu8

@vikiival vikiival merged commit 80ab358 into kodadot:main Aug 17, 2023
14 checks passed
@roiLeo roiLeo mentioned this pull request Aug 18, 2023
Closed
This was referenced Aug 18, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roiLeo @vikiival @Jarsen136 @prury