Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update table padding #6756

Merged
merged 3 commits into from
Aug 18, 2023
Merged

style: update table padding #6756

merged 3 commits into from
Aug 18, 2023

Conversation

floyd-li
Copy link
Member

@floyd-li floyd-li commented Aug 17, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
图片

Copilot Summary

🤖 Generated by Copilot at e62bb13

Increased the padding of some components in the GalleryItemActivity tab to improve the layout and alignment with the design. Modified GalleryItemActivity.vue and GalleryItemActivityTable.vue files.

🤖 Generated by Copilot at e62bb13

padding adjusts
more space and consistency
autumn design breathes

@floyd-li floyd-li requested a review from a team as a code owner August 17, 2023 13:15
@floyd-li floyd-li requested review from vikiival and Jarsen136 and removed request for a team August 17, 2023 13:15
@kodabot
Copy link
Collaborator

kodabot commented Aug 17, 2023

SUCCESS @floyd-li PR for issue #6743 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit b7137b7
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64de2fa38076100008ddf2bf
😎 Deploy Preview https://deploy-preview-6756--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 17, 2023

AI-Generated Summary: This pull request contains changes related to the styling of some elements in the gallery component. It includes modifications to the padding inside two vue files, specifically 'GalleryItemActivity.vue' and 'GalleryItemActivityTable.vue'. The patches show adjusted padding values for certain div and table class elements to enhance the visual layout of these components.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 17, 2023
@roiLeo roiLeo requested a review from exezbcz August 17, 2023 13:18
…le.vue

Co-authored-by: roiLeo <medina.leo42@gmail.com>
@exezbcz
Copy link
Member

exezbcz commented Aug 17, 2023

the hover is not full-width in the container
image

  • otherwise good

@@ -1,6 +1,6 @@
<template>
<div class="gallery-activity-events-wrapper is-flex is-flex-direction-column">
<div class="events p-5 is-flex is-flex-direction-column">
<div class="events py-5 px-6 is-flex is-flex-direction-column">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to use p-5?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

px py value is different. one is 5 and one is 6

@codeclimate
Copy link

codeclimate bot commented Aug 17, 2023

Code Climate has analyzed commit b7137b7 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 17, 2023
@yangwao
Copy link
Member

yangwao commented Aug 18, 2023

pay 30 usd

@yangwao yangwao merged commit f4b53cd into kodadot:main Aug 18, 2023
14 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 18, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.48 USD/DOT ~ 6.696 $DOT
🧗 13rv1SWoLg9Gb3tmvHPZxb7JbVy51BtMziX7k9WQGSJ7Kp3A
🔗 0x0edd6b41fac5090cff39932d3db22ba9633ffb058c2e09031eefc299af094d42

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 18, 2023
This was referenced Aug 18, 2023
@floyd-li floyd-li deleted the fix/6743 branch October 8, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity tab gallery item left right padding
8 participants