Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect modal style #6795

Merged
merged 2 commits into from
Aug 20, 2023
Merged

fix: redirect modal style #6795

merged 2 commits into from
Aug 20, 2023

Conversation

floyd-li
Copy link
Member

@floyd-li floyd-li commented Aug 18, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
图片 ## Copilot Summary

🤖 Generated by Copilot at d810288

Fixed a bug and improved the style of the redirect modal component. Added a z-index to the redirect-modal class and a neo theme to the rootClass in RedirectModal.vue and useRedirectModal.ts.

🤖 Generated by Copilot at d810288

redirect-modal
z-index fixes the bug
autumn leaves fall

@floyd-li floyd-li requested a review from a team as a code owner August 18, 2023 15:31
@floyd-li floyd-li requested review from vikiival and daiagi and removed request for a team August 18, 2023 15:31
@kodabot
Copy link
Collaborator

kodabot commented Aug 18, 2023

SUCCESS @floyd-li PR for issue #6792 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit cdfbda8
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64df91b6690a760008f36a98
😎 Deploy Preview https://deploy-preview-6795--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 18, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 18, 2023

AI-Generated Summary: This pull request includes changes in the 'RedirectModal.vue' and 'useRedirectModal.ts' components of the application. The '.redirect-modal .modal-content' CSS class in 'RedirectModal.vue' is replaced with '.redirect-modal' and a z-index property is added. Also, the 'rootClass' in 'useRedirectModal.ts' is updated to include 'neo-modal' in addition to 'redirect-modal'. It seems to be a fix intended to improve the style and overlay positioning of the redirect modal.

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Aug 18, 2023

Code Climate has analyzed commit cdfbda8 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Aug 20, 2023

pay 30 usd

@yangwao yangwao merged commit d4ef45a into kodadot:main Aug 20, 2023
14 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 20, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.52 USD/DOT ~ 6.637 $DOT
🧗 13rv1SWoLg9Gb3tmvHPZxb7JbVy51BtMziX7k9WQGSJ7Kp3A
🔗 0xfc6fe93c1b2136217c30ab518d339c025ff395bf7ca076bccba8d19cbdf6dadb

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 20, 2023
This was referenced Aug 20, 2023
@floyd-li floyd-li deleted the fix/6792 branch October 8, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅ small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External link modal styling
6 participants