Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show royalty recipient in the Gallery Item #6796

Merged
merged 2 commits into from
Aug 19, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Aug 18, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at 96251bc

This pull request adds a feature to show the royalty recipient of an NFT on the details page. It modifies the GalleryItemDescription.vue component, the en.json locale file, and the nftById.graphql query to display and fetch the recipient data.

🤖 Generated by Copilot at 96251bc

recipient field
added to GraphQL query
autumn of NFTs

@Jarsen136 Jarsen136 requested a review from a team as a code owner August 18, 2023 15:32
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team August 18, 2023 15:32
@kodabot
Copy link
Collaborator

kodabot commented Aug 18, 2023

SUCCESS @Jarsen136 PR for issue #6787 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 7fe29e8
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64df90eea99d3e00088fbb3f
😎 Deploy Preview https://deploy-preview-6796--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 18, 2023

AI-Generated Summary: This pull request introduces a feature that displays the royalty recipient in the Gallery Item component of the application. The changes include enhancements made to the 'GalleryItemDescription.vue', 'en.json', and 'nftById.graphql' files. In 'GalleryItemDescription.vue', a new HTML div segment has been added to show the royalty recipient's details. The locale file 'en.json' has been updated to include a new label for the 'Royalty recipient'. Lastly, the 'nftById.graphql' query has been enhanced to fetch the recipient's data in addition to the existing data fields. Overall, this update will improve the information displayed for each gallery item, particularly pertaining to royalties.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 18, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 18, 2023

Code Climate has analyzed commit 7fe29e8 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.0% 2.0% Duplication

@yangwao
Copy link
Member

yangwao commented Aug 19, 2023

pay 50 usd

@yangwao yangwao merged commit dcd4396 into kodadot:main Aug 19, 2023
14 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 19, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.49 USD/DOT ~ 11.136 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0xf45fbadbc9973805be0b572d69db64fa3eb9113cfdf16c8172db8f8f9890acb1

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅ small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show royalty recipient in the Gallery Item
5 participants