Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust query in landing page #6810

Merged
merged 1 commit into from
Aug 19, 2023
Merged

fix: adjust query in landing page #6810

merged 1 commit into from
Aug 19, 2023

Conversation

preschian
Copy link
Member

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

@netlify
Copy link

netlify bot commented Aug 19, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ea6e16a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e0909d9d509f00082a920b
😎 Deploy Preview https://deploy-preview-6810--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 19, 2023

AI-Generated Summary: This pull request includes critical changes to query adjustments on the landing page. In the file useCarousel.ts, several unnecessary imports were removed and the condition for disabling chains was simplified; instead of having separate conditions for isProduction and isBeta, both were combined into the same condition. The usage and structure of useChainEvents and flattenNFT functions were also drastically updated. The useSearchNfts.ts file was updated to take in additional arguments for prefix and orderBy, therefore enhancing the flexibility of search functions. Overall, these changes might result in better performance, readability, and maintainability of the code.

@codeclimate
Copy link

codeclimate bot commented Aug 19, 2023

Code Climate has analyzed commit ea6e16a and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad reviewpad bot added the small Pull request is small label Aug 19, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 19, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@preschian
Copy link
Member Author

It seems like we don't need the lastEvent query for the carousel on the landing page. Since we already had nftEntities or events query

in this PR I try to change the query with nftEntities

wdyt? @vikiival @roiLeo

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@preschian preschian marked this pull request as ready for review August 19, 2023 10:12
@preschian preschian requested a review from a team as a code owner August 19, 2023 10:12
@preschian preschian requested review from vikiival and daiagi and removed request for a team August 19, 2023 10:12
@yangwao
Copy link
Member

yangwao commented Aug 19, 2023

pay 50 usd

@yangwao yangwao merged commit bc8b924 into main Aug 19, 2023
14 checks passed
@yangwao yangwao deleted the fix/landing-carousel-query branch August 19, 2023 12:26
@yangwao
Copy link
Member

yangwao commented Aug 19, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.48 USD/DOT ~ 11.161 $DOT
🧗 1xjvRADwdJcnmUCLWerEHR4iGCT5EBTm4D4fzLLg4LcAC9p
🔗 0x5e1bf69eeb2f3c89091a736aa3b00c6d738fbbecf9b4f8645def6eb3a78b2249

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants