-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(useRedirectModal): Switch button items and activity at collection view opens new page and cart button on explorer too #6826
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request addresses an issue where an event listener was affecting all links across the application. The proposed changes alter the way the 'useRedirectModal' function is being utilized. Instead of targeting a string, it now takes in a reference to an HTML element. These modifications have mainly been implemented in two files: 'useRedirectModal.ts' in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
Co-authored-by: Preschian Febryantara <preschian@users.noreply.github.com>
Code Climate has analyzed commit 0045a72 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
pay 50 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
The event listener inside
useRedirectModal
was affecting the entire website and not just the items inside the target node in this case the .content-markdownDid your issue had any of the "$" label on it?
Community participation
Screenshot 📸
CleanShot.2023-08-20.at.09.29.57.mp4
Copilot Summary
🤖 Generated by Copilot at 7afa09a
Improved the
useRedirectModal
function to use element references and added a link confirmation feature to theMarkdown
component.🤖 Generated by Copilot at 7afa09a