Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useRedirectModal): Switch button items and activity at collection view opens new page and cart button on explorer too #6826

Merged
merged 2 commits into from
Aug 20, 2023

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Aug 20, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

The event listener inside useRedirectModal was affecting the entire website and not just the items inside the target node in this case the .content-markdown

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

CleanShot.2023-08-20.at.09.29.57.mp4

Copilot Summary

🤖 Generated by Copilot at 7afa09a

Improved the useRedirectModal function to use element references and added a link confirmation feature to the Markdown component.

🤖 Generated by Copilot at 7afa09a

Sing, O Muse, of the skillful refactorer
Who made the code more swift and error-free
By using ref and useRedirectModal
To handle links with grace and clarity

@hassnian hassnian requested a review from a team as a code owner August 20, 2023 04:32
@hassnian hassnian requested review from preschian and vikiival and removed request for a team August 20, 2023 04:32
@kodabot
Copy link
Collaborator

kodabot commented Aug 20, 2023

SUCCESS @hassnian PR for issue #6817 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 20, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 0045a72
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e198c5fbc149000899e190
😎 Deploy Preview https://deploy-preview-6826--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 20, 2023

AI-Generated Summary: This pull request addresses an issue where an event listener was affecting all links across the application. The proposed changes alter the way the 'useRedirectModal' function is being utilized. Instead of targeting a string, it now takes in a reference to an HTML element. These modifications have mainly been implemented in two files: 'useRedirectModal.ts' in the components/redirect directory, and 'Markdown.vue' in the components/shared directory. This approach aims to increase the function's specificity and reduce the likelihood of unintentional event triggering.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 20, 2023
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

components/redirect/useRedirectModal.ts Outdated Show resolved Hide resolved
Co-authored-by: Preschian Febryantara <preschian@users.noreply.github.com>
@codeclimate
Copy link

codeclimate bot commented Aug 20, 2023

Code Climate has analyzed commit 0045a72 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yangwao
Copy link
Member

yangwao commented Aug 20, 2023

pay 50 usd

@yangwao yangwao merged commit a1d03f2 into kodadot:main Aug 20, 2023
14 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 20, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.5 USD/DOT ~ 11.111 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0x6cd2a86a0cdfa93c7da308b651b08091749f600823443ced2cff9d81be007195

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 20, 2023
@hassnian hassnian deleted the issue-6817 branch August 20, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅ small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch button items and activity at collection view opens new page and cart button on explorer too
6 participants