Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page scroll over 3d models #7452

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Oct 2, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at 2084f64

Added a new prop to MediaItem and its subcomponents to disable zoom and play actions on media items. This prop is used by the CarouselMedia component to show media items in the carousel without these actions.

🤖 Generated by Copilot at 2084f64

We're sailing on the web with our media galore
We've got MediaItem, NeoNftCard and more
But when we show them in the carousel, we don't want them to zoom or play
So we added disable-operation to keep them in their place

@Jarsen136 Jarsen136 requested a review from a team as a code owner October 2, 2023 06:30
@Jarsen136 Jarsen136 requested review from preschian and floyd-li and removed request for a team October 2, 2023 06:30
@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit 892a7c3
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/651a74cd9611200008f37e6a
😎 Deploy Preview https://deploy-preview-7452--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Oct 2, 2023

SUCCESS @Jarsen136 PR for issue #7442 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 2, 2023

AI-Generated Summary: This pull request is a bug fix for a page scroll issue in the context of 3D models. The changes involve several files, including CarouselMedia.vue, MediaItem.vue, ModelMedia.vue, and NeoNftCard.vue. The disable-operation attribute has been added to prevent unwanted interactions with the 3D models. Code modifications include updates to handle characteristics like disableOperation and disable-zoom. Furthermore, these changes also streamline the way 3D models are rendered and managed within the application's UI elements.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 2, 2023
@Jarsen136 Jarsen136 marked this pull request as draft October 2, 2023 06:53
@Jarsen136 Jarsen136 marked this pull request as ready for review October 2, 2023 07:44
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 2, 2023
@yangwao
Copy link
Member

yangwao commented Oct 3, 2023

pay 20 usd

@yangwao yangwao merged commit 9beed17 into kodadot:nuxt Oct 3, 2023
9 checks passed
@yangwao
Copy link
Member

yangwao commented Oct 3, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 4.14 USD/DOT ~ 4.831 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x7f962ec00cbd3b492830c05c2a398058a99996776edff635dfbd624e15698b79

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

page scroll over 3d models
5 participants