Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Nuxt 3 #7583

Merged
merged 790 commits into from
Oct 10, 2023
Merged

⬆️ Nuxt 3 #7583

merged 790 commits into from
Oct 10, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 10, 2023 •
edited
Loading

hassnian and others added 30 commits October 3, 2023 16:41
@hassnian
ref: rename
e7f6a87
@hassnian
ref: rename
a8de7ad
@hassnian
Revert "ref: rename"
a835cdb 
This reverts commit a8de7ad.
@hassnian
Merge branch 'nuxt' into issue-7437
12fe1ea
@roiLeo
Merge branch 'nuxt' into nuxt/issue-02
8fec891
@preschian
refactor: modelValue on switch and drop
0123984
@preschian
Merge branch 'nuxt' of github.com:kodadot/nft-gallery into fix/reduce…
2448fb8 
…-network-request
@preschian
chore:: reduce prefetch page
d3cab9a
@preschian
fix: create collection asset hub
8761683
@preschian
chore: emit modelValue
6b36fa0
@preschian
chore: typo event
48b623e
@yangwao
Merge pull request #7493 from hassnian/issue-7437
4b523b4 
feat: improve profile tabs item count load time
@preschian
fix: useGraphql
5a74ce7
@preschian
chore: unused checker here
f94085c
@roiLeo
Merge branch 'nuxt' into refactor/model-value-switch-and-upload
d08308d
@roiLeo
Merge pull request #7498 from kodadot/refactor/model-value-switch-and…
cd3a1f6 
…-upload

fix: create collection asset hub
@roiLeo
Merge branch 'nuxt' into fix/reduce-network-request
75bbf48
@roiLeo
Merge pull request #7481 from kodadot/fix/reduce-network-request
f8f1453 
fix: reduce network requests on explore/items
@roiLeo
Merge branch 'nuxt' into nuxt/issue-02
24f4fa9
@roiLeo
Merge pull request #7479 from hassnian/nuxt/issue-02
4ee07d9 
fix: [nuxt-3] Gallery Item List and Transfer NFT issues
@preschian
Merge branch 'nuxt' of github.com:kodadot/nft-gallery into fix/use-gr…
c8153ba 
…aphql
@preschian
fix: seo collection pages
b8edd04
@preschian
fix: import neo icon
00d058d
@preschian
fix: create nft
20275eb
@preschian @roiLeo
Update components/carousel/utils/useCarouselSpotlight.ts
74bbfc0 
Co-authored-by: roiLeo <medina.leo42@gmail.com>
@preschian @Jarsen136
Update composables/useGraphql.ts
ed1c9e2 
Co-authored-by: Jarsen <31397967+Jarsen136@users.noreply.github.com>
@kkukelka
[skip ci] updated code diagram
3cc6129
@preschian
chore: use address instead
bc19a7d
@roiLeo
Merge pull request #7503 from kodadot/action
fb5865d 
[skip ci] updated code diagram
@preschian
chore: reactive on clientName
186a197
codeclimate[bot]
codeclimate bot reviewed Oct 10, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 36477 lines exceeds the maximum allowed for the inline comments feature.

preschian
preschian approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WeDidItKarenCheeGIF

codeclimate[bot]
codeclimate bot reviewed Oct 10, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 36570 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Oct 10, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 36416 lines exceeds the maximum allowed for the inline comments feature.

@prury
Copy link
Member

prury commented Oct 10, 2023

WAIT, look what happens when i click on create -> collection:

bugnuxt.mp4

@yangwao
Copy link
Member

yangwao commented Oct 10, 2023

image

@prury
Copy link
Member

prury commented Oct 10, 2023

  • found some minor white/dark mode and icon related bugs
  • explore -> collection: images not loading

what's the best path? merging this one and continue to pursue #7375 ?

@roiLeo
Copy link
Contributor Author

roiLeo commented Oct 10, 2023

  • found some minor white/dark mode and icon related bugs

    • explore -> collection: images not loading

what's the best path? merging this one and continue to pursue #7375 ?

Oops I might have made a change in #7586 and #7585 that is breaking the UI, let me check again

@roiLeo roiLeo mentioned this pull request Oct 10, 2023
Merged
codeclimate[bot]
codeclimate bot reviewed Oct 10, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 36412 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Oct 10, 2023

Code Climate has analyzed commit e22bde7 and detected 9 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 5
Duplication 4

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 10, 2023
@yangwao yangwao merged commit acbcda8 into main Oct 10, 2023
14 of 15 checks passed
This was referenced Oct 11, 2023
Merged
Merged
@roiLeo roiLeo mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate left review comments

@github-actions github-actions[bot] github-actions left review comments

@preschian preschian preschian approved these changes

@prury prury prury approved these changes

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

@yangwao yangwao Awaiting requested review from yangwao

@vikiival vikiival Awaiting requested review from vikiival

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136

@floyd-li floyd-li Awaiting requested review from floyd-li

Assignees
No one assigned
Labels
large Pull request is large S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet